Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(data/multiset/basic): remove sub lemmas #9578

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - refactor(data/multiset/basic): remove sub lemmas #9578

wants to merge 8 commits into from

Conversation

fpvandoorn
Copy link
Member

@fpvandoorn fpvandoorn commented Oct 6, 2021 •
edited by github-actions bot

  • Remove the multiset sub lemmas that are special cases of lemmas in algebra/order/sub
  • This gives the list of renamings.
  • Use derive in pnat.factors.

Open in Gitpod

@fpvandoorn fpvandoorn added the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 6, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 6, 2021
@fpvandoorn fpvandoorn changed the title Protect multiset refactor(data/multiset/basic): remove sub lemmas Oct 6, 2021
@github-actions github-actions bot removed awaiting-CI The author would like to see what CI has to say before doing more work. blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Oct 6, 2021
@github-actions
Copy link

github-actions bot commented Oct 6, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 6, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 7, 2021
@fpvandoorn fpvandoorn added the awaiting-review The author would like community review of the PR label Oct 7, 2021
jcommelin
jcommelin approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 8, 2021
bors bot pushed a commit that referenced this pull request Oct 8, 2021
@fpvandoorn
refactor(data/multiset/basic): remove sub lemmas (#9578)
c3768cc 
* Remove the multiset sub lemmas that are special cases of lemmas in `algebra/order/sub`
* [This](https://github.com/leanprover-community/mathlib/blob/14c3324143beef6e538f63da9c48d45f4a949604/src/data/multiset/basic.lean#L1513-L1538) gives the list of renamings.
* Use `derive` in `pnat.factors`.



Co-authored-by: Floris van Doorn <fpv@andrew.cmu.edu>
@bors
Copy link

bors bot commented Oct 8, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(data/multiset/basic): remove sub lemmas [Merged by Bors] - refactor(data/multiset/basic): remove sub lemmas Oct 8, 2021
@bors bors bot closed this Oct 8, 2021
@bors bors bot deleted the protect_multiset branch October 8, 2021 10:04
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fpvandoorn @jcommelin @eric-wieser