Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/polynomial): assorted lemmas on division and gcd of polynomials #9600

Closed
wants to merge 6 commits into from

Conversation

Vierkantor
Copy link
Collaborator

@Vierkantor Vierkantor commented Oct 7, 2021

This PR provides a couple of lemmas involving the division and gcd operators of polynomials that I needed for #9563. The ones that generalized to euclidean_domain and/or gcd_monoid are provided in the respective files.


Open in Gitpod

@Vierkantor Vierkantor added the awaiting-review The author would like community review of the PR label Oct 7, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 8, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 25, 2021
@Ruben-VandeVelde
Copy link
Collaborator

@Vierkantor it would perhaps be better to cut the dependency on #9606 again, and let me deal with the merge conflicts - will be more fun than the timeouts anyway.

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 8, 2021
@Vierkantor Vierkantor removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Nov 8, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 11, 2021
bors bot pushed a commit that referenced this pull request Nov 11, 2021
…ials (#9600)

This PR provides a couple of lemmas involving the division and gcd operators of polynomials that I needed for #9563. The ones that generalized to `euclidean_domain` and/or `gcd_monoid` are provided in the respective files.



Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@bors
Copy link

bors bot commented Nov 11, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/polynomial): assorted lemmas on division and gcd of polynomials [Merged by Bors] - feat(data/polynomial): assorted lemmas on division and gcd of polynomials Nov 11, 2021
@bors bors bot closed this Nov 11, 2021
@bors bors bot deleted the polynomial-div-gcd-lemmas branch November 11, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants