Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(set_theory/cardinal): lemmas #9690

Closed
wants to merge 10 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented Oct 13, 2021

  • swap sides of cardinal.lift_mk, rename it to cardinal.mk_ulift;
  • add cardinal.out_mk_equiv.

Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Oct 13, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 13, 2021
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 13, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Oct 14, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 15, 2021
@semorrison semorrison added the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 15, 2021
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 16, 2021
@urkud
Copy link
Member

urkud commented Oct 16, 2021

Could you please list API changes in the commit message? Otherwise LGTM. Thanks!
bors d+

@bors
Copy link

bors bot commented Oct 16, 2021

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 16, 2021
@urkud
Copy link
Member

urkud commented Oct 16, 2021

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 16, 2021
bors bot pushed a commit that referenced this pull request Oct 16, 2021
* swap sides of `cardinal.lift_mk`, rename it to `cardinal.mk_ulift`;
* add `cardinal.out_mk_equiv`.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Oct 16, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(set_theory/cardinal): lemmas [Merged by Bors] - feat(set_theory/cardinal): lemmas Oct 16, 2021
@bors bors bot closed this Oct 16, 2021
@bors bors bot deleted the cardinal_lemmas branch October 16, 2021 21:46
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants