[Merged by Bors] - feat(algebra/group_power/order): When a power is less than one #9700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
the
awaiting-review
github-actions
bot
added
the
merge-conflict
YaelDillies
referenced
this pull request
Oct 13, 2021
…e_lt_pow` (#9696) `[linear_ordered_semiring R]` becomes `[ordered_semiring R] [nontrivial R]`. I also golf the proof and move ìt from `algebra.field_power` to `algebra.group_power.order`, where it belongs.
github-actions
bot
removed
the
merge-conflict
urkud
reviewed
Oct 16, 2021
urkud
reviewed
Oct 16, 2021
urkud
reviewed
Oct 16, 2021
|
Otherwise LGTM. Thanks! |
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
Thanks for the reviews! bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2021
This proves a bunch of simple order lemmas relating `1`, `a` and `a ^ n`. I also move `pow_le_one` upstream as it could already be proved in `algebra.group_power.order` and remove `[nontrivial R]` from `one_lt_pow`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
eric-wieser
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proves a bunch of simple order lemmas relating
1,aanda ^ n. I also movepow_le_oneupstream as it could already be proved inalgebra.group_power.orderand remove[nontrivial R]fromone_lt_pow.