Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(number_theory/liouville): the set of Liouville numbers has measure zero #9702

Closed
wants to merge 28 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 13, 2021

As a corollary, the filters residual ℝ and volume.ae are disjoint.


Open in Gitpod

@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes needs-documentation This PR is missing required documentation labels Oct 13, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 13, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 14, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 16, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 22, 2021
@urkud urkud added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR and removed needs-documentation This PR is missing required documentation awaiting-author A reviewer has asked the author a question or requested changes labels Oct 22, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 22, 2021
@github-actions github-actions bot removed awaiting-CI The author would like to see what CI has to say before doing more work. blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Oct 22, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

end

/-- If a number is Liouville with exponent `p`, then it is Liouville with any smaller exponent. -/
lemma mono (h : liouville_with p x) (hle : q ≤ p) : liouville_with q x :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be antimono?

Suggested change
lemma mono (h : liouville_with p x) (hle : q ≤ p) : liouville_with q x :=
lemma antimono (h : liouville_with p x) (hle : q ≤ p) : liouville_with q x :=

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use mono for, e.g., set.countable.mono.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that predates the introduction of antimono. Anyway, I don't have a strong opinion on this.

src/number_theory/liouville/liouville_with.lean Outdated Show resolved Hide resolved
src/number_theory/liouville/measure.lean Outdated Show resolved Hide resolved
Co-authored-by: Johan Commelin <johan@commelin.net>
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Oct 25, 2021

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jcommelin jcommelin added awaiting-CI The author would like to see what CI has to say before doing more work. ready-for-bors labels Oct 25, 2021
@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 25, 2021
@urkud urkud removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 25, 2021
@urkud
Copy link
Member Author

urkud commented Oct 25, 2021

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 25, 2021
bors bot pushed a commit that referenced this pull request Oct 25, 2021
…re zero (#9702)

As a corollary, the filters `residual ℝ` and `volume.ae` are disjoint.
@bors
Copy link

bors bot commented Oct 26, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(number_theory/liouville): the set of Liouville numbers has measure zero [Merged by Bors] - feat(number_theory/liouville): the set of Liouville numbers has measure zero Oct 26, 2021
@bors bors bot closed this Oct 26, 2021
@bors bors bot deleted the urkud/liouville-with branch October 26, 2021 00:32
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 26, 2021
ericrbg pushed a commit that referenced this pull request Nov 9, 2021
…re zero (#9702)

As a corollary, the filters `residual ℝ` and `volume.ae` are disjoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-for-bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants