Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/group_power/lemmas): Positivity of an odd/even power #9796

Closed
wants to merge 4 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Oct 19, 2021

This adds odd.pow_nonneg and co and pow_right_comm.
This also deletes pow_odd_nonneg and pow_odd_pos as they are special cases of pow_nonneg and pow_pos.
To make dot notation work, this renames (pow/fpow)_(odd/even)_(nonneg/nonpos/pos/neg/abs) to (odd/even).(pow/fpow)_(nonneg/nonpos/pos/neg/abs)


Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Oct 19, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using dot-notation, which is great. But shouldn't it be used in the rest of the file as well.
pow_even_pos could become even.pow_pos and your even.pow_pos would be even_pow_pos_iff. What do you think?

@YaelDillies
Copy link
Collaborator Author

Absolutely! I was thinking that too.

@urkud
Copy link
Member

urkud commented Oct 21, 2021

Could you please list all API changes in the commit message?

@urkud
Copy link
Member

urkud commented Oct 21, 2021

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 21, 2021
bors bot pushed a commit that referenced this pull request Oct 21, 2021
)

This adds `odd.pow_nonneg` and co and `pow_right_comm`.
This also deletes `pow_odd_nonneg` and `pow_odd_pos` as they are special cases of `pow_nonneg` and `pow_pos`.
To make dot notation work, this renames `(pow/fpow)_(odd/even)_(nonneg/nonpos/pos/neg/abs)` to `(odd/even).(pow/fpow)_(nonneg/nonpos/pos/neg/abs)`
@bors
Copy link

bors bot commented Oct 21, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/group_power/lemmas): Positivity of an odd/even power [Merged by Bors] - feat(algebra/group_power/lemmas): Positivity of an odd/even power Oct 21, 2021
@bors bors bot closed this Oct 21, 2021
@bors bors bot deleted the pow_odd branch October 21, 2021 22:46
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 26, 2021
ericrbg pushed a commit that referenced this pull request Nov 9, 2021
)

This adds `odd.pow_nonneg` and co and `pow_right_comm`.
This also deletes `pow_odd_nonneg` and `pow_odd_pos` as they are special cases of `pow_nonneg` and `pow_pos`.
To make dot notation work, this renames `(pow/fpow)_(odd/even)_(nonneg/nonpos/pos/neg/abs)` to `(odd/even).(pow/fpow)_(nonneg/nonpos/pos/neg/abs)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants