-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(algebra/group_power/lemmas): Positivity of an odd/even power #9796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are using dot-notation, which is great. But shouldn't it be used in the rest of the file as well.
pow_even_pos
could become even.pow_pos
and your even.pow_pos
would be even_pow_pos_iff
. What do you think?
Absolutely! I was thinking that too. |
Could you please list all API changes in the commit message? |
bors merge |
) This adds `odd.pow_nonneg` and co and `pow_right_comm`. This also deletes `pow_odd_nonneg` and `pow_odd_pos` as they are special cases of `pow_nonneg` and `pow_pos`. To make dot notation work, this renames `(pow/fpow)_(odd/even)_(nonneg/nonpos/pos/neg/abs)` to `(odd/even).(pow/fpow)_(nonneg/nonpos/pos/neg/abs)`
Pull request successfully merged into master. Build succeeded: |
) This adds `odd.pow_nonneg` and co and `pow_right_comm`. This also deletes `pow_odd_nonneg` and `pow_odd_pos` as they are special cases of `pow_nonneg` and `pow_pos`. To make dot notation work, this renames `(pow/fpow)_(odd/even)_(nonneg/nonpos/pos/neg/abs)` to `(odd/even).(pow/fpow)_(nonneg/nonpos/pos/neg/abs)`
This adds
odd.pow_nonneg
and co andpow_right_comm
.This also deletes
pow_odd_nonneg
andpow_odd_pos
as they are special cases ofpow_nonneg
andpow_pos
.To make dot notation work, this renames
(pow/fpow)_(odd/even)_(nonneg/nonpos/pos/neg/abs)
to(odd/even).(pow/fpow)_(nonneg/nonpos/pos/neg/abs)