Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(algebra/module/submodule_lattice): correct bad lemma #9809

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

This lemma was accidentally stating that inf and inter are the same on sets, and wasn't about submodule at all.

The old statement was ↑p ⊓ ↑q = ↑p ∩ ↑q, the new one is ↑(p ⊓ q) = ↑p ∩ ↑q


Open in Gitpod

This lemma was accidentally stating that inf and inter are the same on sets, and wasn't about submodule at all.

The old statement was `↑p ⊓ ↑q = ↑p ∩ ↑q`, the new one is `↑(p ⊓ q) = ↑p ∩ ↑q`
@eric-wieser eric-wieser added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Oct 19, 2021
@jcommelin
Copy link
Member

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Oct 19, 2021

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jcommelin jcommelin added awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-review The author would like community review of the PR labels Oct 19, 2021
@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-CI The author would like to see what CI has to say before doing more work. labels Oct 19, 2021
@eric-wieser
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 20, 2021
bors bot pushed a commit that referenced this pull request Oct 20, 2021
This lemma was accidentally stating that inf and inter are the same on sets, and wasn't about submodule at all.

The old statement was `↑p ⊓ ↑q = ↑p ∩ ↑q`, the new one is `↑(p ⊓ q) = ↑p ∩ ↑q`
@bors
Copy link

bors bot commented Oct 20, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(algebra/module/submodule_lattice): correct bad lemma [Merged by Bors] - fix(algebra/module/submodule_lattice): correct bad lemma Oct 20, 2021
@bors bors bot closed this Oct 20, 2021
@bors bors bot deleted the eric-wieser/fix-submodule-inf branch October 20, 2021 13:22
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 26, 2021
ericrbg pushed a commit that referenced this pull request Nov 9, 2021
This lemma was accidentally stating that inf and inter are the same on sets, and wasn't about submodule at all.

The old statement was `↑p ⊓ ↑q = ↑p ∩ ↑q`, the new one is `↑(p ⊓ q) = ↑p ∩ ↑q`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants