Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory/ideal/over): algebra structure on R/p → S/P for P lying over p #9858

Closed
wants to merge 3 commits into from

Conversation

Vierkantor
Copy link
Collaborator

@Vierkantor Vierkantor commented Oct 21, 2021

This PR shows P lies over p if there is an injective map completing the square R/p ← R —f→ S → S/P, and conversely that there is a (not necessarily injective, since f doesn't have to be) map completing the square if P lies over p. Then we specialize this to the case where P = map f p to provide an algebra p.quotient (map f p).quotient instance.

This algebra instance is useful if you want to study the extension R → S locally at p, e.g. to show R/p : S/pS has the same dimension as Frac(R) : Frac(S) if p is prime.


Open in Gitpod

@Vierkantor Vierkantor added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. awaiting-CI The author would like to see what CI has to say before doing more work. labels Oct 21, 2021
@github-actions github-actions bot removed awaiting-CI The author would like to see what CI has to say before doing more work. blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Oct 21, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 27, 2021
Vierkantor and others added 3 commits November 8, 2021 11:31
Co-Authored-By: Johan Commelin <johan@commelin.net>
Co-Authored-By: Eric Wieser <wieser.eric@gmail.com>
@Vierkantor Vierkantor force-pushed the ideal-quotient_algebra_quotient branch from 789bdb6 to 80ae071 Compare November 8, 2021 11:38
@Vierkantor Vierkantor added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 8, 2021
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Nov 8, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

bors bot pushed a commit that referenced this pull request Nov 10, 2021
… lying over `p` (#9858)

This PR shows `P` lies over `p` if there is an injective map completing the square `R/p ← R —f→ S → S/P`, and conversely that there is a (not necessarily injective, since `f` doesn't have to be) map completing the square if `P` lies over `p`. Then we specialize this to the case where `P = map f p` to provide an `algebra p.quotient (map f p).quotient` instance.

This algebra instance is useful if you want to study the extension `R → S` locally at `p`, e.g. to show `R/p : S/pS` has the same dimension as `Frac(R) : Frac(S)` if `p` is prime.
@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 10, 2021
@sgouezel
Copy link
Collaborator

bors r+

bors bot pushed a commit that referenced this pull request Nov 10, 2021
… lying over `p` (#9858)

This PR shows `P` lies over `p` if there is an injective map completing the square `R/p ← R —f→ S → S/P`, and conversely that there is a (not necessarily injective, since `f` doesn't have to be) map completing the square if `P` lies over `p`. Then we specialize this to the case where `P = map f p` to provide an `algebra p.quotient (map f p).quotient` instance.

This algebra instance is useful if you want to study the extension `R → S` locally at `p`, e.g. to show `R/p : S/pS` has the same dimension as `Frac(R) : Frac(S)` if `p` is prime.
@bors
Copy link

bors bot commented Nov 10, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/ideal/over): algebra structure on R/p → S/P for P lying over p [Merged by Bors] - feat(ring_theory/ideal/over): algebra structure on R/p → S/P for P lying over p Nov 10, 2021
@bors bors bot closed this Nov 10, 2021
@bors bors bot deleted the ideal-quotient_algebra_quotient branch November 10, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants