[Merged by Bors] - refactor(data/mv_polynomial): upgrade monomial to a linear_map
#9870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
urkud
commented
Oct 22, 2021
urkud
commented
eric-wieser
reviewed
Oct 22, 2021
Comment on lines
-218
to
-219
| @[simp] lemma monomial_add {s : σ →₀ ℕ} {a b : R} : | ||
| monomial s a + monomial s b = monomial s (a + b) := |
There was a problem hiding this comment.
I think it's worth keeping this even if we don't mark it simp any more; we still have polynomial.monomial_add
There was a problem hiding this comment.
I think it's fine to remove it. Especially with the fun_like refactor around the corner, I'm happy to get rid off all these lemmas.
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
monomial to a linear_mapmonomial to a linear_map
eric-wieser
added
the
hacktoberfest-accepted
ericrbg
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.