Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/limits/shapes/images): some explicit instances of has_image_map #9977

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(category_theory/limits/shapes/images): some explicit instances of has_image_map #9977

wants to merge 7 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin commented Oct 26, 2021 •
edited by github-actions bot

@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Oct 26, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 26, 2021
@jcommelin jcommelin mentioned this pull request Oct 26, 2021
Closed
1 task
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 28, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 28, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 28, 2021
adamtopaz
adamtopaz reviewed Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@adamtopaz adamtopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments.

src/category_theory/limits/shapes/images.lean Outdated Show resolved Hide resolved
src/category_theory/limits/shapes/images.lean Outdated Show resolved Hide resolved
src/category_theory/limits/shapes/images.lean Outdated Show resolved Hide resolved
@adamtopaz adamtopaz added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 28, 2021
jcommelin and others added 3 commits October 29, 2021 05:23
@jcommelin jcommelin added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 29, 2021
@adamtopaz
Copy link
Collaborator

LGTM!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 29, 2021
bors bot pushed a commit that referenced this pull request Oct 29, 2021
@jcommelin
feat(category_theory/limits/shapes/images): some explicit instances o…
e1bafaa 
…f has_image_map (#9977)
@bors
Copy link

bors bot commented Oct 29, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/limits/shapes/images): some explicit instances of has_image_map [Merged by Bors] - feat(category_theory/limits/shapes/images): some explicit instances of has_image_map Oct 29, 2021
@bors bors bot closed this Oct 29, 2021
@bors bors bot deleted the image-map-instances branch October 29, 2021 15:33
ericrbg pushed a commit that referenced this pull request Nov 9, 2021
@jcommelin @ericrbg
feat(category_theory/limits/shapes/images): some explicit instances o…
c1b5f10 
…f has_image_map (#9977)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamtopaz adamtopaz adamtopaz left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcommelin @adamtopaz