Fixing walks_and_trees branch #9983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pechersky
reviewed
Oct 26, 2021
| { simp only [multiset.singleton_eq_singleton, multiset.count_eq_zero, multiset.mem_singleton], | ||
| exact ne.symm hne, }, | ||
| { simp only [multiset.singleton_eq_cons, multiset.count_eq_zero, multiset.mem_singleton], | ||
| simp, exact ne.symm hne, }, |
There was a problem hiding this comment.
You should try to avoid non-terminal simps. You can likely switch this proof to end in simpa using ne.symm hne. Likely you can even make the whole proof simpa [multiset.singleton_eq_singleton, multiset.count_eq_zero, multiset.mem_singleton] using ne.symm hne.
kmill
approved these changes
Oct 26, 2021
| nat.succ_eq_add_one, this, set.mem_Union, nat.nat_zero_eq_zero, finset.coe_bUnion, | ||
| finset.mem_univ, set.Union_true, list.nodup_nil, set.mem_set_of_eq, exists_imp_distrib, | ||
| iff_false, finset.mem_coe, false_and | ||
| ], |
There was a problem hiding this comment.
Mathlib doesn't seem to ever put the simp lemmas on their own line like this. If you could rewrap the lines so it's in the following form, I'd appreciate it:
simp! only [...............................
.........................................
.........................................]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symtyposmultiset.singleton_eq_singletontomultiset.singleton_eq_consis_rotated_append(already enunciated and proved indata.list)