[Merged by Bors] - refactor(*): rename fpow and gpow to zpow #9989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgouezel
added
the
awaiting-review
eric-wieser
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
bors d+
I haven't looked through the whole diff, but you caught the other case I was looking for zpowers. Just to check, if the replacement of gpowers with zpowers was accidental, did this change pick up any other gpow substrings accidentally? (edit: checked in gitpod, looks fine)
Also, I adjusted the PR description to mention gsmul.
|
✌️ sgouezel can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
Yes, I had to do some fine-tweaking after a global search-and replace. For instance, bors r+ |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
Historically, we had two notions of integer power, one on groups called `gpow` and the other one on fields called `fpow`. Since the introduction of `div_inv_monoid` and `group_with_zero`, these definitions have been merged into one, and the boundaries are not clear any more. We rename both of them to `zpow`, adding a subscript `0` to disambiguate lemma names when there is a collision, where the subscripted version is for groups with zeroes (as is already done for inv lemmas). To limit the scope of the change. this PR does not rename `gsmul` to `zsmul` or `gmultiples` to `zmultiples`.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
Historically, we had two notions of integer power, one on groups called `gpow` and the other one on fields called `fpow`. Since the introduction of `div_inv_monoid` and `group_with_zero`, these definitions have been merged into one, and the boundaries are not clear any more. We rename both of them to `zpow`, adding a subscript `0` to disambiguate lemma names when there is a collision, where the subscripted version is for groups with zeroes (as is already done for inv lemmas). To limit the scope of the change. this PR does not rename `gsmul` to `zsmul` or `gmultiples` to `zmultiples`.
|
bors r+ |
|
Already running a review |
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
Historically, we had two notions of integer power, one on groups called `gpow` and the other one on fields called `fpow`. Since the introduction of `div_inv_monoid` and `group_with_zero`, these definitions have been merged into one, and the boundaries are not clear any more. We rename both of them to `zpow`, adding a subscript `0` to disambiguate lemma names when there is a collision, where the subscripted version is for groups with zeroes (as is already done for inv lemmas). To limit the scope of the change. this PR does not rename `gsmul` to `zsmul` or `gmultiples` to `zmultiples`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ericrbg
pushed a commit
that referenced
this pull request
Nov 9, 2021
Historically, we had two notions of integer power, one on groups called `gpow` and the other one on fields called `fpow`. Since the introduction of `div_inv_monoid` and `group_with_zero`, these definitions have been merged into one, and the boundaries are not clear any more. We rename both of them to `zpow`, adding a subscript `0` to disambiguate lemma names when there is a collision, where the subscripted version is for groups with zeroes (as is already done for inv lemmas). To limit the scope of the change. this PR does not rename `gsmul` to `zsmul` or `gmultiples` to `zmultiples`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, we had two notions of integer power, one on groups called
gpowand the other one on fields calledfpow. Since the introduction ofdiv_inv_monoidandgroup_with_zero, these definitions have been merged into one, and the boundaries are not clear any more. We rename both of them tozpow, adding a subscript0to disambiguate lemma names when there is a collision, where the subscripted version is for groups with zeroes (as is already done for inv lemmas).To limit the scope of the change. this PR does not rename
gsmultozsmulorgmultiplestozmultiples.