Skip to content

Commit

Permalink
chore(UniqueFactorizationDomain): golf (#11424)
Browse files Browse the repository at this point in the history
Move `factors_zero` up, use it to golf `ne_zero_of_mem_factors`
  • Loading branch information
urkud committed Mar 17, 2024
1 parent d94dbff commit 4203419
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions Mathlib/RingTheory/UniqueFactorizationDomain.lean
Expand Up @@ -476,10 +476,13 @@ theorem factors_prod {a : α} (ane0 : a ≠ 0) : Associated (factors a).prod a :
exact (Classical.choose_spec (exists_prime_factors a ane0)).2
#align unique_factorization_monoid.factors_prod UniqueFactorizationMonoid.factors_prod

@[simp]
theorem factors_zero : factors (0 : α) = 0 := by simp [factors]
#align unique_factorization_monoid.factors_zero UniqueFactorizationMonoid.factors_zero

theorem ne_zero_of_mem_factors {p a : α} (h : p ∈ factors a) : a ≠ 0 := by
intro ha
rw [factors, dif_pos ha] at h
exact Multiset.not_mem_zero _ h
rintro rfl
simp at h
#align unique_factorization_monoid.ne_zero_of_mem_factors UniqueFactorizationMonoid.ne_zero_of_mem_factors

theorem dvd_of_mem_factors {p a : α} (h : p ∈ factors a) : p ∣ a :=
Expand All @@ -496,10 +499,6 @@ theorem irreducible_of_factor {a : α} : ∀ x : α, x ∈ factors a → Irreduc
(prime_of_factor x h).irreducible
#align unique_factorization_monoid.irreducible_of_factor UniqueFactorizationMonoid.irreducible_of_factor

@[simp]
theorem factors_zero : factors (0 : α) = 0 := by simp [factors]
#align unique_factorization_monoid.factors_zero UniqueFactorizationMonoid.factors_zero

@[simp]
theorem factors_one : factors (1 : α) = 0 := by
nontriviality α using factors
Expand Down

0 comments on commit 4203419

Please sign in to comment.