Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting note: added simp #11227

Open
pitmonticone opened this issue Mar 7, 2024 · 0 comments
Open

Porting note: added simp #11227

pitmonticone opened this issue Mar 7, 2024 · 0 comments
Labels
porting-notes Mathlib3 to Mathlib4 porting notes.

Comments

@pitmonticone
Copy link
Collaborator

Classifies porting notes claiming anything equivalent to:

  • "added dsimp"
  • "dsimp added"
  • "dsimp now needed"

Examples

/-- Given representations of `G` on `V` and `W`, there is a natural representation of `G` on the
module `V →ₗ[k] W`, where `G` acts by conjugation.
-/
def linHom : Representation k G (V →ₗ[k] W) where
toFun g :=
{ toFun := fun f => ρW g ∘ₗ f ∘ₗ ρV g⁻¹
map_add' := fun f₁ f₂ => by simp_rw [add_comp, comp_add]
map_smul' := fun r f => by simp_rw [RingHom.id_apply, smul_comp, comp_smul] }
map_one' :=
LinearMap.ext fun x => by
dsimp -- Porting note: now needed
simp_rw [inv_one, map_one, one_eq_id, comp_id, id_comp]
map_mul' g h :=
LinearMap.ext fun x => by
dsimp -- Porting note: now needed
simp_rw [mul_inv_rev, map_mul, mul_eq_comp, comp_assoc]
#align representation.lin_hom Representation.linHom

/--
The cocone at `*` for the stalk functor of `skyscraperPresheaf p₀ A` when `y ∉ closure {p₀}` is a
colimit
-/
noncomputable def skyscraperPresheafCoconeIsColimitOfNotSpecializes {y : X} (h : ¬p₀ ⤳ y) :
IsColimit (skyscraperPresheafCocone p₀ A y) :=
let h1 : ∃ U : OpenNhds y, p₀ ∉ U.1 :=
let ⟨U, ho, h₀, hy⟩ := not_specializes_iff_exists_open.mp h
⟨⟨⟨U, ho⟩, h₀⟩, hy⟩
{ desc := fun c => eqToHom (if_neg h1.choose_spec).symm ≫ c.ι.app (op h1.choose)
fac := fun c U => by
change _ = c.ι.app (op U.unop)
simp only [← c.w (homOfLE <| @inf_le_left _ _ h1.choose U.unop).op, ←
c.w (homOfLE <| @inf_le_right _ _ h1.choose U.unop).op, ← Category.assoc]
congr 1
refine' ((if_neg _).symm.ndrec terminalIsTerminal).hom_ext _ _
exact fun h => h1.choose_spec h.1
uniq := fun c f H => by
dsimp -- Porting note: added a `dsimp`
rw [← Category.id_comp f, ← H, ← Category.assoc]
congr 1; apply terminalIsTerminal.hom_ext }
#align skyscraper_presheaf_cocone_is_colimit_of_not_specializes skyscraperPresheafCoconeIsColimitOfNotSpecializes

@pitmonticone pitmonticone added the porting-notes Mathlib3 to Mathlib4 porting notes. label Mar 7, 2024
mathlib-bors bot pushed a commit that referenced this issue Mar 9, 2024
Classifies by adding issue number #11227 to porting notes claiming anything equivalent to: 

- "added `dsimp`"
- "`dsimp` added"
- "`dsimp` now needed"
kbuzzard pushed a commit that referenced this issue Mar 12, 2024
Classifies by adding issue number #11227 to porting notes claiming anything equivalent to: 

- "added `dsimp`"
- "`dsimp` added"
- "`dsimp` now needed"
dagurtomas pushed a commit that referenced this issue Mar 22, 2024
Classifies by adding issue number #11227 to porting notes claiming anything equivalent to: 

- "added `dsimp`"
- "`dsimp` added"
- "`dsimp` now needed"
utensil pushed a commit that referenced this issue Mar 26, 2024
Classifies by adding issue number #11227 to porting notes claiming anything equivalent to: 

- "added `dsimp`"
- "`dsimp` added"
- "`dsimp` now needed"
Louddy pushed a commit that referenced this issue Apr 15, 2024
Classifies by adding issue number #11227 to porting notes claiming anything equivalent to: 

- "added `dsimp`"
- "`dsimp` added"
- "`dsimp` now needed"
uniwuni pushed a commit that referenced this issue Apr 19, 2024
Classifies by adding issue number #11227 to porting notes claiming anything equivalent to: 

- "added `dsimp`"
- "`dsimp` added"
- "`dsimp` now needed"
callesonne pushed a commit that referenced this issue Apr 22, 2024
Classifies by adding issue number #11227 to porting notes claiming anything equivalent to: 

- "added `dsimp`"
- "`dsimp` added"
- "`dsimp` now needed"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
porting-notes Mathlib3 to Mathlib4 porting notes.
Projects
None yet
Development

No branches or pull requests

1 participant