Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Natural abs syntax clashes with pattern matching #307

Closed
abentkamp opened this issue Dec 14, 2021 · 3 comments
Closed

Natural abs syntax clashes with pattern matching #307

abentkamp opened this issue Dec 14, 2021 · 3 comments
Labels
help-wanted The author needs attention to resolve issues

Comments

@abentkamp
Copy link

The notation for abs clashes with some variants of the match notation:

import Mathbin.Algebra.Abs -- works if this is not imported

def test : Nat → Nat
| 0 => 0  -- expected '|'
| n + 1 => 0
@gebner
Copy link
Member

gebner commented Dec 15, 2021

gebner referenced this issue in leanprover-community/mathport Jan 25, 2022
@gebner gebner transferred this issue from leanprover-community/mathport Jul 18, 2022
@gebner
Copy link
Member

gebner commented Jul 18, 2022

Transferred to mathlib4 because we've solved the issue in mathport (by just ignoring the notation).

We still need to figure out a notation for the absolute value in Lean 4 though.

@gebner gebner changed the title abs syntax clash Natural abs syntax clashes with pattern matching Jul 18, 2022
@gebner gebner added the help-wanted The author needs attention to resolve issues label Jul 18, 2022
@gebner
Copy link
Member

gebner commented Oct 31, 2022

#477 added the |abs| notation.

@gebner gebner closed this as completed Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted The author needs attention to resolve issues
Projects
None yet
Development

No branches or pull requests

2 participants