[Merged by Bors] - feat: port algebra.abs #477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickMassot
force-pushed
the
algebra_abs
branch
from
e961a68
to
65957ba
Compare
|
See #307 |
PatrickMassot
force-pushed
the
algebra_abs
branch
from
edef99a
to
24a95ca
Compare
|
I changed the notation following a suggestion by Sebastian. I also force pushed to make sure the first commit is the result of mathport, as suggested by Heather. |
|
This is an interesting choice! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 18, 2022
Note that `mathport` completely dropped the line ``notation `|`a`|` := abs a`` in https://github.com/leanprover-community/mathlib3port/blob/5a66d9b4aff2f94aabca7f3daead2a383d7f2117/Mathbin/Algebra/Abs.lean.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
|
I've have added the FROZEN warning to algebra.abs in leanprover-community/mathlib#17039. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that
mathportcompletely dropped the linenotation `|`a`|` := abs ain https://github.com/leanprover-community/mathlib3port/blob/5a66d9b4aff2f94aabca7f3daead2a383d7f2117/Mathbin/Algebra/Abs.lean.