Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wlog tactic gives error application type mismatch #5348

Closed
dwrensha opened this issue Jun 21, 2023 · 1 comment
Closed

wlog tactic gives error application type mismatch #5348

dwrensha opened this issue Jun 21, 2023 · 1 comment

Comments

@dwrensha
Copy link
Member

When I try this:

import Mathlib.Tactic.WLOG
import Mathlib.Data.Nat.Basic

example (x y : ℕ) : True := by
  let z := 10 -- works as expected if this line is commented out
  wlog hxy' : x < y with H
  · trivial
  · trivial

I get this error:

application type mismatch
  (let z := 10;
    fun hxy' ↦ True.intro)
    z
argument has type
  ℕ
but function has type
  x < y → True

I suspect that the tactic logic is missing a withContext call or similar.

@dwrensha
Copy link
Member Author

cc @thorimur

bors bot pushed a commit that referenced this issue Jun 28, 2023
`wlog` was erroneously supplying all reverted fvars to `mkAppN`, instead of just supplying the ones which weren't ldecls. This fixes #5348.
bors bot pushed a commit that referenced this issue Jun 28, 2023
`wlog` was erroneously supplying all reverted fvars to `mkAppN`, instead of just supplying the ones which weren't ldecls. This fixes #5348.
@bors bors bot closed this as completed in 79657c3 Jun 28, 2023
semorrison pushed a commit that referenced this issue Jun 29, 2023
`wlog` was erroneously supplying all reverted fvars to `mkAppN`, instead of just supplying the ones which weren't ldecls. This fixes #5348.
kbuzzard pushed a commit that referenced this issue Jul 6, 2023
`wlog` was erroneously supplying all reverted fvars to `mkAppN`, instead of just supplying the ones which weren't ldecls. This fixes #5348.
semorrison pushed a commit that referenced this issue Aug 14, 2023
`wlog` was erroneously supplying all reverted fvars to `mkAppN`, instead of just supplying the ones which weren't ldecls. This fixes #5348.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant