Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard names for topological spaces #9866

Open
grunweg opened this issue Jan 20, 2024 · 1 comment
Open

Use standard names for topological spaces #9866

grunweg opened this issue Jan 20, 2024 · 1 comment
Labels
t-topology Topological spaces, uniform spaces, metric spaces, filters

Comments

@grunweg
Copy link
Collaborator

grunweg commented Jan 20, 2024

Currently, many old files (in topology and elsewhere) still use Greek letters for topological spaces.
Newer files use e.g. the letters X, Y and Z. We should switch to using these everywhere (per Zulip discussion.

A lot of files have already been converted, but there is still a fair number to go.

Which files are affected? As an approximation, search for files containing the string TopologicalSpace α. As of January 20th, 2024, there are 95 such files in Topology alone (of which 3 have open PRs), and 145 files in all of mathlib.

How to replace? What to look out for?

  • I compiled a checklist here.
  • VS Code's rename handler is useful for renaming variables: go to the declaration site (e.g. a variable statement mentioning something like {α : Type*} or {α : Type u}, select the variable name and press F2.
    Sometimes, that doesn't catch all occurrences and you need to rename again. You'll also need to check if docstrings mention α.
@grunweg grunweg added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Jan 20, 2024
@YaelDillies
Copy link
Collaborator

I think using α makes a lot of sense to mean an unspecified topological space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

No branches or pull requests

2 participants