-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Topology/Separation): rename type variables #7589
Conversation
Please make sure to put your description above the The space below the |
Note my comments above are far from exhaustive: I just looked for a few examples that were particularly messy. It's certainly not a requirement that you catch all of them, but you're making a tradeoff here between "Greek letters are weird" and "some variables have actively misleading names", and you need to ensure it's not so many that the change is a net downgrade. |
I hear your concern and agree this is important. I've checked all of the following to catch as many instances as possible. (This covers all instances you pointed out, and also the comments in #7587.)
|
31f4e8e
to
23d27c0
Compare
I am not sure if the last commit is actually a net positive: certainly, the variable name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
Thanks!
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Thank you for the review. I have addressed both nits (as well as another analogous case in this file.) |
This file was using a mix of Greek letters and standard math convention (X, Y, Z). `connectedComponent_eq_iInter_clopen` was even using `X` in comments and $\alpha$ in the code. As [discussed](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Naming.20convention.3A.20topological.20spaces/near/395769893) on zulip, standardize on the latter.
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file was using a mix of Greek letters and standard math convention (X, Y, Z). `connectedComponent_eq_iInter_clopen` was even using `X` in comments and $\alpha$ in the code. As [discussed](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Naming.20convention.3A.20topological.20spaces/near/395769893) on zulip, standardize on the latter.
This file was using a mix of Greek letters and standard math convention (X, Y, Z). `connectedComponent_eq_iInter_clopen` was even using `X` in comments and $\alpha$ in the code. As [discussed](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Naming.20convention.3A.20topological.20spaces/near/395769893) on zulip, standardize on the latter.
This file was using a mix of Greek letters and standard math convention (X, Y, Z).
$\alpha$ in the code.
connectedComponent_eq_iInter_clopen
was even usingX
in comments andAs discussed on zulip, standardize on the latter.