Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(CategoryTheory/Limits/KanExtension): generalize assumptions #10003

Closed
wants to merge 1 commit into from

Conversation

yuma-mizuno
Copy link
Collaborator


Open in Gitpod

@yuma-mizuno yuma-mizuno added awaiting-review The author would like community review of the PR t-category-theory Category theory labels Jan 25, 2024
@joelriou
Copy link
Collaborator

I am obviously ok with these changes, but I think that a more significant refactor of Kan extensions should be done someday. In order to develop derived functors in the mathlib branch jriou_localization, I have sketched some API for left Kan extension in the files CategoryTheory.Functor.KanExtension and CategoryTheory.Functor.KanExtension.Pointwise in that branch https://github.com/leanprover-community/mathlib4/tree/jriou_localization . (Part of the basic definitions there are related to the definitions you introduced for bicategories; but because of universe heterogeneity, we cannot use these directly.)

@yuma-mizuno
Copy link
Collaborator Author

yuma-mizuno commented Jan 26, 2024

@joelriou Thank you for sharing your project. I'm excited to see Kan extensions and derived functors stuff in mathlib.

Should we expect the content in the current Kan extension file to be completely rewritten in some way?

@joelriou
Copy link
Collaborator

Should we expect the content in the current Kan extension file to be completely rewritten in some way?

I would think so, but I would try to keep a certain API compatibility...

@joelriou
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 30, 2024
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 30, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory/Limits/KanExtension): generalize assumptions [Merged by Bors] - feat(CategoryTheory/Limits/KanExtension): generalize assumptions Jan 30, 2024
@mathlib-bors mathlib-bors bot closed this Jan 30, 2024
@mathlib-bors mathlib-bors bot deleted the ymizuno-kan-condition branch January 30, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants