[Merged by Bors] - feat: Add NumberField.is_primitive_element_of_infinitePlace_lt
#10033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xroblot
added
awaiting-review
Closed
3 tasks
jcommelin
reviewed
Feb 13, 2024
jcommelin
added
awaiting-author
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
…ement_of_infinitePlace_lt
…nitePlace_lt' into xfr-is_primitive_element_of_infinitePlace_lt
xroblot
added
awaiting-review
riccardobrasca
approved these changes
Feb 18, 2024
|
✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
…ement_of_infinitePlace_lt
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
) Prove the following ```lean theorem NumberField.is_primitive_element_of_infinitePlace_lt (x : 𝓞 K) {w : InfinitePlace K} (h₁ : x ≠ 0) (h₂ : ∀ ⦃w'⦄, w' ≠ w → w' x < 1) (h₃ : IsReal w ∨ |(w.embedding x).re| < 1) : ℚ⟮(x:K)⟯ = ⊤ := by ``` If the place `w` is not real, we need the condition `|(w.embedding x).re| < 1` to ensure `x` is not a real number at the place `w`.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
NumberField.is_primitive_element_of_infinitePlace_ltNumberField.is_primitive_element_of_infinitePlace_lt
mathlib-bors
bot
deleted the
xfr-is_primitive_element_of_infinitePlace_lt
branch
riccardobrasca
pushed a commit
that referenced
this pull request
Feb 19, 2024
) Prove the following ```lean theorem NumberField.is_primitive_element_of_infinitePlace_lt (x : 𝓞 K) {w : InfinitePlace K} (h₁ : x ≠ 0) (h₂ : ∀ ⦃w'⦄, w' ≠ w → w' x < 1) (h₃ : IsReal w ∨ |(w.embedding x).re| < 1) : ℚ⟮(x:K)⟯ = ⊤ := by ``` If the place `w` is not real, we need the condition `|(w.embedding x).re| < 1` to ensure `x` is not a real number at the place `w`.
thorimur
pushed a commit
that referenced
this pull request
Feb 24, 2024
) Prove the following ```lean theorem NumberField.is_primitive_element_of_infinitePlace_lt (x : 𝓞 K) {w : InfinitePlace K} (h₁ : x ≠ 0) (h₂ : ∀ ⦃w'⦄, w' ≠ w → w' x < 1) (h₃ : IsReal w ∨ |(w.embedding x).re| < 1) : ℚ⟮(x:K)⟯ = ⊤ := by ``` If the place `w` is not real, we need the condition `|(w.embedding x).re| < 1` to ensure `x` is not a real number at the place `w`.
thorimur
pushed a commit
that referenced
this pull request
Feb 26, 2024
) Prove the following ```lean theorem NumberField.is_primitive_element_of_infinitePlace_lt (x : 𝓞 K) {w : InfinitePlace K} (h₁ : x ≠ 0) (h₂ : ∀ ⦃w'⦄, w' ≠ w → w' x < 1) (h₃ : IsReal w ∨ |(w.embedding x).re| < 1) : ℚ⟮(x:K)⟯ = ⊤ := by ``` If the place `w` is not real, we need the condition `|(w.embedding x).re| < 1` to ensure `x` is not a real number at the place `w`.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
) Prove the following ```lean theorem NumberField.is_primitive_element_of_infinitePlace_lt (x : 𝓞 K) {w : InfinitePlace K} (h₁ : x ≠ 0) (h₂ : ∀ ⦃w'⦄, w' ≠ w → w' x < 1) (h₃ : IsReal w ∨ |(w.embedding x).re| < 1) : ℚ⟮(x:K)⟯ = ⊤ := by ``` If the place `w` is not real, we need the condition `|(w.embedding x).re| < 1` to ensure `x` is not a real number at the place `w`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prove the following
If the place
wis not real, we need the condition|(w.embedding x).re| < 1to ensurexis not a real number at the placew.