Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Set.Prod #1004

Closed
wants to merge 15 commits into from
Closed

[Merged by Bors] - feat: port Data.Set.Prod #1004

wants to merge 15 commits into from

Conversation

semorrison
Copy link
Contributor

@semorrison semorrison commented Dec 14, 2022 •
edited

fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e

@semorrison
Copy link
Contributor Author

Sorry, I hadn't seen #978. I've merged three proofs from that branch into this.

@semorrison semorrison mentioned this pull request Dec 14, 2022
Closed
@semorrison semorrison added awaiting-review The author would like community review of the PR merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Dec 14, 2022
@PatrickMassot PatrickMassot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 14, 2022
@ChrisHughes24
Copy link
Member

bors merge

@ChrisHughes24
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Dec 14, 2022

Canceled.

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 14, 2022
@ChrisHughes24 ChrisHughes24 added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge This PR has been sent to bors. labels Dec 14, 2022
@semorrison semorrison added help-wanted The author needs attention to resolve issues WIP Work in progress and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 14, 2022
@semorrison
Copy link
Contributor Author

This PR/issue depends on:

@ChrisHughes24 ChrisHughes24 removed the help-wanted The author needs attention to resolve issues label Dec 14, 2022
@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. and removed WIP Work in progress labels Dec 14, 2022
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Dec 14, 2022
View reviewed changes
Mathlib/Data/Set/Prod.lean Outdated Show resolved Hide resolved
Mathlib/Data/Set/Prod.lean Outdated Show resolved Hide resolved
Mathlib/Data/Set/Prod.lean Show resolved Hide resolved
Mathlib/Data/Set/Prod.lean Outdated Show resolved Hide resolved
Mathlib/Data/Set/Prod.lean Outdated Show resolved Hide resolved
ChrisHughes24 and others added 2 commits December 14, 2022 15:21
@ChrisHughes24 @Ruben-VandeVelde
Apply suggestions from code review
472bcf2 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@ChrisHughes24
one name change
ba95705
@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 14, 2022
bors bot pushed a commit that referenced this pull request Dec 14, 2022
@semorrison @PatrickMassot @ChrisHughes24
feat: port Data.Set.Prod (#1004)
a5d78c3 
fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e

- [x] depends on: #1000

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Dec 14, 2022
Closed
@bors
Copy link

bors bot commented Dec 14, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Set.Prod [Merged by Bors] - feat: port Data.Set.Prod Dec 14, 2022
@bors bors bot closed this Dec 14, 2022
@bors bors bot deleted the data_set_prod branch December 14, 2022 17:04
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Dec 15, 2022
@leanprover-community-bot @j-loreaux
chore(*): add mathlib4 synchronization comments (#17943)
a59dad5 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.euclidean_domain.basic`: leanprover-community/mathlib4#919
* `algebra.field.basic`: leanprover-community/mathlib4#975
* `algebra.group.opposite`: leanprover-community/mathlib4#912
* `algebra.group.prod`: leanprover-community/mathlib4#968
* `algebra.group.with_one.units`: leanprover-community/mathlib4#955
* `algebra.group_power.ring`: leanprover-community/mathlib4#979
* `algebra.hom.equiv.type_tags`: leanprover-community/mathlib4#943
* `algebra.hom.ring`: leanprover-community/mathlib4#958
* `algebra.invertible`: leanprover-community/mathlib4#930
* `algebra.order.field.canonical.basic`: leanprover-community/mathlib4#1018
* `algebra.order.field.canonical.defs`: leanprover-community/mathlib4#985
* `algebra.order.field.inj_surj`: leanprover-community/mathlib4#1017
* `algebra.order.group.densely_ordered`: leanprover-community/mathlib4#956
* `algebra.order.group.min_max`: leanprover-community/mathlib4#933
* `algebra.order.group.prod`: leanprover-community/mathlib4#1026
* `algebra.order.group.with_top`: leanprover-community/mathlib4#946
* `algebra.order.hom.monoid`: leanprover-community/mathlib4#944
* `algebra.order.monoid.prod`: leanprover-community/mathlib4#987
* `algebra.order.monoid.to_mul_bot`: leanprover-community/mathlib4#1024
* `algebra.order.ring.abs`: leanprover-community/mathlib4#929
* `algebra.order.ring.cone`: leanprover-community/mathlib4#935
* `algebra.order.sub.basic`: leanprover-community/mathlib4#936
* `algebra.order.sub.with_top`: leanprover-community/mathlib4#932
* `algebra.order.with_zero`: leanprover-community/mathlib4#903
* `combinatorics.quiver.arborescence`: leanprover-community/mathlib4#997
* `combinatorics.quiver.cast`: leanprover-community/mathlib4#990
* `control.traversable.lemmas`: leanprover-community/mathlib4#948
* `data.bool.set`: leanprover-community/mathlib4#960
* `data.int.cast.field`: leanprover-community/mathlib4#1016
* `data.int.cast.lemmas`: leanprover-community/mathlib4#995
* `data.int.cast.prod`: leanprover-community/mathlib4#1015
* `data.int.div`: leanprover-community/mathlib4#1011
* `data.int.dvd.basic`: leanprover-community/mathlib4#996
* `data.int.order.basic`: leanprover-community/mathlib4#938
* `data.nat.cast.basic`: leanprover-community/mathlib4#980
* `data.nat.cast.prod`: leanprover-community/mathlib4#1010
* `data.nat.cast.with_top`: leanprover-community/mathlib4#1019
* `data.nat.gcd.basic`: leanprover-community/mathlib4#965
* `data.nat.order.basic`: leanprover-community/mathlib4#907
* `data.nat.order.lemmas`: leanprover-community/mathlib4#927
* `data.nat.set`: leanprover-community/mathlib4#961
* `data.nat.upto`: leanprover-community/mathlib4#1020
* `data.pequiv`: leanprover-community/mathlib4#1008
* `data.set.basic`: leanprover-community/mathlib4#892
* `data.set.bool_indicator`: leanprover-community/mathlib4#988
* `data.set.image`: leanprover-community/mathlib4#949
* `data.set.n_ary`: leanprover-community/mathlib4#969
* `data.set.opposite`: leanprover-community/mathlib4#983
* `data.set.prod`: leanprover-community/mathlib4#1004
* `data.set.sigma`: leanprover-community/mathlib4#982
* `data.set_like.basic`: leanprover-community/mathlib4#993
* `data.two_pointing`: leanprover-community/mathlib4#984
* `logic.embedding.set`: leanprover-community/mathlib4#986
* `logic.equiv.embedding`: leanprover-community/mathlib4#1021
* `order.directed`: leanprover-community/mathlib4#963
* `order.rel_iso.set`: leanprover-community/mathlib4#1005
* `order.well_founded`: leanprover-community/mathlib4#970
* `ring_theory.coprime.basic`: leanprover-community/mathlib4#899



Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@semorrison @ChrisHughes24 @fpvandoorn @Ruben-VandeVelde @PatrickMassot