Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: make (x : M) implicit in extChartAt_image_nhd_mem_nhds_of_boundaryless #10081

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore: make (x : M) implicit in extChartAt_image_nhd_mem_nhds_of_boundaryless #10081

wants to merge 1 commit into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jan 28, 2024

Fixes an oversight in #10001: x is already included in the hypothesis hx, so should be implicit.
A follow-up PR will address this issue more systematically.

Open in Gitpod

@grunweg
chore: make (x : M) implicit in `extChartAt_image_nhd_mem_nhds_of_bou…
0992c82 
…ndaryless`

Fixes an oversight in #9894: x is already included in the hypothesis `hx`,
so should be implicit.
A follow-up PR will address this issue more systematically.
@grunweg grunweg added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-differential-geometry Manifolds etc labels Jan 28, 2024
winstonyin
winstonyin approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@winstonyin winstonyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward.

@ocfnash
Copy link
Contributor

ocfnash commented Jan 31, 2024

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 31, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 31, 2024
@grunweg
chore: make (x : M) implicit in `extChartAt_image_nhd_mem_nhds_of_bou…
58df996 
…ndaryless` (#10081)

Fixes an oversight in #10001: x is already included in the hypothesis `hx`, so should be implicit.
A follow-up PR will address this issue more systematically.
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 31, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: make (x : M) implicit in extChartAt_image_nhd_mem_nhds_of_boundaryless [Merged by Bors] - chore: make (x : M) implicit in extChartAt_image_nhd_mem_nhds_of_boundaryless Jan 31, 2024
@mathlib-bors mathlib-bors bot closed this Jan 31, 2024
@mathlib-bors mathlib-bors bot deleted the MR-fixup-9894 branch January 31, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winstonyin winstonyin winstonyin approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grunweg @ocfnash @winstonyin