Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(PartialHomeomorph): Remove explicit variable (x : M). #10083

Closed
wants to merge 7 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jan 28, 2024

Instead, supply it as needed.

This replaces an explicit argument (x : M) by an implicit {x : M} in the following lemmas:

  • extChartAt_source_mem_nhds'
  • extChartAt_source_mem_nhdsWithin'
  • continuousAt_extChartAt'
  • extChartAt_image_nhd_mem_nhds_of_boundaryless
  • extChartAt_target_mem_nhdsWithin'
  • nhdsWithin_extChartAt_target_eq'
  • continuousAt_extChartAt_symm'
  • continuousAt_extChartAt_symm''
  • map_extChartAt_nhdsWithin_eq_image'
  • map_extChartAt_nhdsWithin'
  • map_extChartAt_symm_nhdsWithin'
  • map_extChartAt_symm_nhdsWithin_range'
  • extChartAt_preimage_mem_nhdsWithin'
  • extChartAt_preimage_mem_nhdsWithin
  • extChartAt_preimage_mem_nhds'
  • extChartAt_preimage_mem_nhds

Open in Gitpod

…daryless

Fixes an oversight in #xxxx: x is already included in a hypothesis, so should be implicit.
Instead, supply it as needed.
This changes map_extChartAt_symm_nhdsWithin'; one unnecessary argument x is dropped.
@grunweg grunweg added awaiting-review The author would like community review of the PR t-differential-geometry Manifolds etc labels Jan 28, 2024
@winstonyin winstonyin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 29, 2024
@grunweg
Copy link
Collaborator Author

grunweg commented Jan 29, 2024

@winstonyin Thank you for the sharp eye. You were right.

@grunweg grunweg added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 29, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 31, 2024
@grunweg grunweg removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 31, 2024
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

Mathlib/Geometry/Manifold/SmoothManifoldWithCorners.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 1, 2024

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 1, 2024
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@grunweg
Copy link
Collaborator Author

grunweg commented Feb 1, 2024

Thank you for the review.
bors r+

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 1, 2024

Canceled.

@grunweg
Copy link
Collaborator Author

grunweg commented Feb 1, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 1, 2024
Instead, supply it as needed.

This replaces an explicit argument (x : M) by an implicit `{x : M}` in the following lemmas:
- extChartAt_source_mem_nhds'
- extChartAt_source_mem_nhdsWithin'
- continuousAt_extChartAt'
- extChartAt_image_nhd_mem_nhds_of_boundaryless
- extChartAt_target_mem_nhdsWithin'
- nhdsWithin_extChartAt_target_eq'
- continuousAt_extChartAt_symm'
- continuousAt_extChartAt_symm''
- map_extChartAt_nhdsWithin_eq_image'
- map_extChartAt_nhdsWithin'
- map_extChartAt_symm_nhdsWithin'
- map_extChartAt_symm_nhdsWithin_range'
- extChartAt_preimage_mem_nhdsWithin'
- extChartAt_preimage_mem_nhdsWithin
- extChartAt_preimage_mem_nhds'
- extChartAt_preimage_mem_nhds



Co-authored-by: grunweg <grunweg@posteo.de>
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(PartialHomeomorph): Remove explicit variable (x : M). [Merged by Bors] - refactor(PartialHomeomorph): Remove explicit variable (x : M). Feb 1, 2024
@mathlib-bors mathlib-bors bot closed this Feb 1, 2024
@mathlib-bors mathlib-bors bot deleted the MR-fixup-extchart-lemma branch February 1, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants