[Merged by Bors] - feat: basic definition of comonoid objects #10091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
semorrison
commented
Jan 29, 2024
semorrison
commented
semorrison
added
awaiting-review
1 task
semorrison
commented
Jan 29, 2024
This was referenced Jan 29, 2024
Closed
semorrison
commented
Jan 29, 2024
joelriou
reviewed
Feb 7, 2024
joelriou
added
awaiting-author
semorrison
added
awaiting-review
TwoFX
reviewed
Mar 26, 2024
| rw [rightUnitor_inv_naturality, tensorHom_def', comul_counit_assoc] | ||
|
|
||
| theorem assoc_flip : | ||
| M.comul ≫ (𝟙 M.X ⊗ M.comul) = M.comul ≫ (M.comul ⊗ 𝟙 M.X) ≫ (α_ M.X M.X M.X).hom := by simp |
There was a problem hiding this comment.
I'm not familiar with the current setup for monoidal categories. It looks to me that neither LHS nor the RHS of this lemma are in simp-normal form due to the simp lemmas id_tensorHom and tensorHom_id. Should the statement be changed? Why doesn't the simpNF linter complain about this?
There was a problem hiding this comment.
simpNF doesn't complain because this isn't a simp lemma!
I fixed this to use whiskering.
There was a problem hiding this comment.
I've actually now changed both the associativity lemmas, to absorb associators, and made both simp. Probably this will break the downstream PRs, whose content I've entirely forgotten by now. :-)
TwoFX
added
awaiting-author
semorrison
added
awaiting-review
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 9, 2024
Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott@tqft.net>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott@tqft.net>
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott@tqft.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.