Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: a linear endomorphism that is a root of a squarefree polynomial is semisimple #10128

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: a linear endomorphism that is a root of a squarefree polynomial is semisimple #10128

wants to merge 7 commits into from

Conversation

ocfnash
Copy link
Contributor

@ocfnash ocfnash commented Jan 30, 2024 •
edited

The main result is Module.End.isSemisimple_of_squarefree_aeval_eq_zero

Open in Gitpod

@ocfnash ocfnash added WIP Work in progress awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Jan 30, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jan 30, 2024
@ocfnash ocfnash added awaiting-review The author would like community review of the PR blocked-by-core-PR and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. WIP Work in progress labels Jan 30, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jan 30, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Jan 31, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 1, 2024
jcommelin
jcommelin reviewed Feb 1, 2024
View reviewed changes
Mathlib/Algebra/Associated.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Semisimple.lean Show resolved Hide resolved
Mathlib/RingTheory/DedekindDomain/Ideal.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 1, 2024
ocfnash and others added 2 commits February 1, 2024 13:29
@ocfnash @jcommelin
Update Mathlib/Algebra/Associated.lean
add465a 
Co-authored-by: Johan Commelin <johan@commelin.net>
@ocfnash
Feedback from CR
0026ff2
@ocfnash ocfnash added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 1, 2024
@jcommelin
Copy link
Member

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 1, 2024

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR awaiting-CI labels Feb 1, 2024
@ocfnash
Copy link
Contributor Author

ocfnash commented Feb 1, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 1, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 1, 2024
@ocfnash
feat: a linear endomorphism that is a root of a squarefree polynomial…
be2a49b 
… is semisimple (#10128)

The main result is `Module.End.isSemisimple_of_squarefree_aeval_eq_zero`
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: a linear endomorphism that is a root of a squarefree polynomial is semisimple [Merged by Bors] - feat: a linear endomorphism that is a root of a squarefree polynomial is semisimple Feb 1, 2024
@mathlib-bors mathlib-bors bot closed this Feb 1, 2024
@mathlib-bors mathlib-bors bot deleted the ocfnash/semisimple_minpoly branch February 1, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ocfnash @leanprover-community-mathlib4-bot @jcommelin