Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(Probability/Kernel/CondCdf): mv atBot_le_nhds_bot/top #10132

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - refactor(Probability/Kernel/CondCdf): mv atBot_le_nhds_bot/top #10132

wants to merge 3 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Jan 30, 2024

Open in Gitpod

@mo271
Copy link
Collaborator Author

mo271 commented Jan 30, 2024

Cannot move to order/filter/at_top_bot as suggested in the todo, because TopologicalSpace is not available there and probably not a good place to import it. Hence moving to Topology/Order/Basic instead.

@mo271 mo271 added awaiting-review The author would like community review of the PR awaiting-CI labels Jan 30, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 31, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 2, 2024
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 14, 2024
@mo271 @sgouezel
Update Mathlib/Probability/Kernel/CondCdf.lean
d44b78d 
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@mo271 mo271 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 14, 2024
@sgouezel
Copy link
Contributor

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 14, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 14, 2024
@mo271
refactor(Probability/Kernel/CondCdf): mv atBot_le_nhds_bot/top (#10132)
ed63382 
Co-authored-by: Moritz Firsching <firsching@google.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 14, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Probability/Kernel/CondCdf): mv atBot_le_nhds_bot/top [Merged by Bors] - refactor(Probability/Kernel/CondCdf): mv atBot_le_nhds_bot/top Feb 14, 2024
@mathlib-bors mathlib-bors bot closed this Feb 14, 2024
@mathlib-bors mathlib-bors bot deleted the mo271/mv_from_prob_kernel6 branch February 14, 2024 11:28
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
@mo271 @riccardobrasca
refactor(Probability/Kernel/CondCdf): mv atBot_le_nhds_bot/top (#10132)
15b3eb7 
Co-authored-by: Moritz Firsching <firsching@google.com>
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@mo271 @dagurtomas
refactor(Probability/Kernel/CondCdf): mv atBot_le_nhds_bot/top (#10132)
44ebc90 
Co-authored-by: Moritz Firsching <firsching@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mo271 @sgouezel @leanprover-community-mathlib4-bot