Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(LocallyConvex/Bounded): add IsVonNBounded.add etc #10135

Closed
wants to merge 7 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 31, 2024

  • add IsVonNBounded.add, IsVonNBounded.vadd,
    and isVonNBounded_vadd;
  • generalize some lemmas in Topology/Algebra/Monoid
    from Monoid to MulOneClass,
    move them to a new section.

Open in Gitpod

* add `IsVonNBounded.add, `IsVonNBounded.vadd`,
  and `isVonNBounded_vadd`;
* generalize some lemmas in `Topology/Algebra/Monoid`
  from `Monoid` to `MulOneClass`,
  move them to a new section.
@urkud urkud added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) labels Jan 31, 2024
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 5, 2024
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 6, 2024
⟨fun h ↦ by simpa using h.vadd (-x), fun h ↦ h.vadd x⟩

theorem IsVonNBounded.right_of_add (hst : IsVonNBounded 𝕜 (s + t)) (hs : s.Nonempty) :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
theorem IsVonNBounded.right_of_add (hst : IsVonNBounded 𝕜 (s + t)) (hs : s.Nonempty) :
theorem IsVonNBounded.of_add_right (hst : IsVonNBounded 𝕜 (s + t)) (hs : s.Nonempty) :

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With of_add_right, it's not clear (for me) whether it's "of adding something on the right" (so this one should be of_add_left, see Int.ModEq.of_mul_left) or "of add, version for right term".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, because both interpretations mean the same thing. We already used this pattern in other places.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this lemma be of_add_left or of_add_right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also used left_of_* in, e.g., left_ne_zero_of_mul. I don't care about this case (e.g., feel free to push a change to this PR) but we should choose one style some day. For now, for all lemmas ending with left/right, I try both every time.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference between left_ne_zero_of_mul and here is that we have access to dot notation here, which means that we flush the left/right to the end of the lemma name.

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the lemmas so that they match Set.Nonempty.of_add_left/Set.Nonempty.of_add_right.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@sgouezel
Copy link
Contributor

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 11, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 11, 2024
* add `IsVonNBounded.add`, `IsVonNBounded.vadd`,
  and `isVonNBounded_vadd`;
* generalize some lemmas in `Topology/Algebra/Monoid`
  from `Monoid` to `MulOneClass`,
  move them to a new section.



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 11, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(LocallyConvex/Bounded): add IsVonNBounded.add etc [Merged by Bors] - feat(LocallyConvex/Bounded): add IsVonNBounded.add etc Feb 11, 2024
@mathlib-bors mathlib-bors bot closed this Feb 11, 2024
@mathlib-bors mathlib-bors bot deleted the YK-bdd-add branch February 11, 2024 14:32
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
* add `IsVonNBounded.add`, `IsVonNBounded.vadd`,
  and `isVonNBounded_vadd`;
* generalize some lemmas in `Topology/Algebra/Monoid`
  from `Monoid` to `MulOneClass`,
  move them to a new section.



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants