-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(LocallyConvex/Bounded): add IsVonNBounded.add
etc
#10135
Conversation
* add `IsVonNBounded.add, `IsVonNBounded.vadd`, and `isVonNBounded_vadd`; * generalize some lemmas in `Topology/Algebra/Monoid` from `Monoid` to `MulOneClass`, move them to a new section.
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
⟨fun h ↦ by simpa using h.vadd (-x), fun h ↦ h.vadd x⟩ | ||
|
||
theorem IsVonNBounded.right_of_add (hst : IsVonNBounded 𝕜 (s + t)) (hs : s.Nonempty) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theorem IsVonNBounded.right_of_add (hst : IsVonNBounded 𝕜 (s + t)) (hs : s.Nonempty) : | |
theorem IsVonNBounded.of_add_right (hst : IsVonNBounded 𝕜 (s + t)) (hs : s.Nonempty) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With of_add_right
, it's not clear (for me) whether it's "of adding something on the right" (so this one should be of_add_left
, see Int.ModEq.of_mul_left
) or "of add, version for right term".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, because both interpretations mean the same thing. We already used this pattern in other places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this lemma be of_add_left
or of_add_right
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also used left_of_*
in, e.g., left_ne_zero_of_mul
. I don't care about this case (e.g., feel free to push a change to this PR) but we should choose one style some day. For now, for all lemmas ending with left
/right
, I try both every time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference between left_ne_zero_of_mul
and here is that we have access to dot notation here, which means that we flush the left
/right
to the end of the lemma name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed the lemmas so that they match Set.Nonempty.of_add_left
/Set.Nonempty.of_add_right
.
maintainer merge
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
bors r+ |
* add `IsVonNBounded.add`, `IsVonNBounded.vadd`, and `isVonNBounded_vadd`; * generalize some lemmas in `Topology/Algebra/Monoid` from `Monoid` to `MulOneClass`, move them to a new section. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Pull request successfully merged into master. Build succeeded: |
IsVonNBounded.add
etcIsVonNBounded.add
etc
* add `IsVonNBounded.add`, `IsVonNBounded.vadd`, and `isVonNBounded_vadd`; * generalize some lemmas in `Topology/Algebra/Monoid` from `Monoid` to `MulOneClass`, move them to a new section. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
IsVonNBounded.add
,IsVonNBounded.vadd
,and
isVonNBounded_vadd
;Topology/Algebra/Monoid
from
Monoid
toMulOneClass
,move them to a new section.