Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(ProperSpace): rename constructors #10138

Closed
wants to merge 4 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 31, 2024

Rename properSpace_of_* to ProperSpace.of_*,
restore old names as deprecated aliases.
This affects:

  • properSpace_of_locallyCompactSpace -> ProperSpace.of_locallyCompactSpace,
    also golf using new ProperSpace.of_seq_closedBall;
  • properSpace_of_locallyCompact_module -> ProperSpace.of_locallyCompact_module;
  • properSpace_of_compact_closedBall_of_le ->
    ProperSpace.of_isCompact_closedBall_of_le,
    also changed compact -> isCompact in the name.

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters t-analysis Analysis (normed *, calculus) labels Jan 31, 2024
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Mathlib/Topology/MetricSpace/ProperSpace.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 31, 2024

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Jan 31, 2024
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@urkud
Copy link
Member Author

urkud commented Jan 31, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 31, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 31, 2024
Rename `properSpace_of_*` to `ProperSpace.of_*`,
restore old names as deprecated aliases.
This affects:

- `properSpace_of_locallyCompactSpace` -> `ProperSpace.of_locallyCompactSpace`,
  also golf using new `ProperSpace.of_seq_closedBall`;
- `properSpace_of_locallyCompact_module` -> `ProperSpace.of_locallyCompact_module`;
- `properSpace_of_compact_closedBall_of_le` ->
  `ProperSpace.of_isCompact_closedBall_of_le`,
  also changed `compact` -> `isCompact` in the name.
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 31, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(ProperSpace): rename constructors [Merged by Bors] - chore(ProperSpace): rename constructors Jan 31, 2024
@mathlib-bors mathlib-bors bot closed this Jan 31, 2024
@mathlib-bors mathlib-bors bot deleted the YK-proper-space-rename branch January 31, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants