Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Algebra/Lie): Engel subalgebras #10158

Closed
wants to merge 9 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin commented Feb 1, 2024

Progress toward #10065


Open in Gitpod

@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Feb 1, 2024
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 1, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 1, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 2, 2024
@jcommelin jcommelin added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 2, 2024
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great.

Apart from the inline nitpicks, I wonder if we should take this as an opportunity to reorganise a few files. E.g., we could have a new LieSubalgebra folder containing:
Basic (current contents of LieSubalgebra.lean)
Cartan
Engel

bors d+

Mathlib/Algebra/Module/LinearMap/End.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Lie/OfAssociative.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Lie/OfAssociative.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Lie/OfAssociative.lean Show resolved Hide resolved
Mathlib/Algebra/Lie/EngelSubalgebra.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Lie/EngelSubalgebra.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 2, 2024

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 2, 2024
@jcommelin
Copy link
Member Author

Apart from the inline nitpicks, I wonder if we should take this as an opportunity to reorganise a few files. E.g., we could have a new LieSubalgebra folder containing: Basic (current contents of LieSubalgebra.lean) Cartan Engel

Sounds good. We can do that in a follow-up as well.

@jcommelin
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 2, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 2, 2024

Build failed (retrying...):

@urkud
Copy link
Member

urkud commented Feb 2, 2024

Please run lake exe shake --fix
bors r-

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 2, 2024

Canceled.

@jcommelin
Copy link
Member Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 3, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Lie): Engel subalgebras [Merged by Bors] - feat(Algebra/Lie): Engel subalgebras Feb 3, 2024
@mathlib-bors mathlib-bors bot closed this Feb 3, 2024
@mathlib-bors mathlib-bors bot deleted the engel-subalgebra branch February 3, 2024 08:02
atarnoam pushed a commit that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants