-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Algebra/Lie): Engel subalgebras #10158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is great.
Apart from the inline nitpicks, I wonder if we should take this as an opportunity to reorganise a few files. E.g., we could have a new LieSubalgebra
folder containing:
Basic
(current contents of LieSubalgebra.lean
)
Cartan
Engel
bors d+
✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with |
Sounds good. We can do that in a follow-up as well. |
bors merge |
Progress toward #10065
Build failed (retrying...): |
Please run |
Canceled. |
bors r+ |
Progress toward #10065
Pull request successfully merged into master. Build succeeded: |
Progress toward #10065