Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(FiniteDimensional): rename lemmas #10188

Closed
wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 2, 2024

Rename lemmas to enable new-style dot notation or drop repeating FiniteDimensional.finiteDimensional_*.
Restore old names as deprecated aliases.


Open in Gitpod

@urkud urkud added awaiting-review t-analysis Analysis (normed *, calculus) t-algebra Algebra (groups, rings, fields etc) labels Feb 2, 2024
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Feb 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 2, 2024
Rename lemmas to enable new-style dot notation or drop repeating `FiniteDimensional.finiteDimensional_*`.
Restore old names as deprecated aliases.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 2, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 2, 2024
Rename lemmas to enable new-style dot notation or drop repeating `FiniteDimensional.finiteDimensional_*`.
Restore old names as deprecated aliases.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(FiniteDimensional): rename lemmas [Merged by Bors] - chore(FiniteDimensional): rename lemmas Feb 2, 2024
@mathlib-bors mathlib-bors bot closed this Feb 2, 2024
@mathlib-bors mathlib-bors bot deleted the YK-findim-rename branch February 2, 2024 22:46
atarnoam pushed a commit that referenced this pull request Feb 9, 2024
Rename lemmas to enable new-style dot notation or drop repeating `FiniteDimensional.finiteDimensional_*`.
Restore old names as deprecated aliases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc) t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants