-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(FiniteDimensional): rename lemmas #10188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
t-analysis
Analysis (normed *, calculus)
t-algebra
Algebra (groups, rings, fields etc)
labels
Feb 2, 2024
jcommelin
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
leanprover-community-mathlib4-bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
labels
Feb 2, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
Rename lemmas to enable new-style dot notation or drop repeating `FiniteDimensional.finiteDimensional_*`. Restore old names as deprecated aliases.
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
Rename lemmas to enable new-style dot notation or drop repeating `FiniteDimensional.finiteDimensional_*`. Restore old names as deprecated aliases.
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore(FiniteDimensional): rename lemmas
[Merged by Bors] - chore(FiniteDimensional): rename lemmas
Feb 2, 2024
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
Rename lemmas to enable new-style dot notation or drop repeating `FiniteDimensional.finiteDimensional_*`. Restore old names as deprecated aliases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has been sent to bors.
t-algebra
Algebra (groups, rings, fields etc)
t-analysis
Analysis (normed *, calculus)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename lemmas to enable new-style dot notation or drop repeating
FiniteDimensional.finiteDimensional_*
.Restore old names as deprecated aliases.