[Merged by Bors] - chore(Data/Finsupp/Fin): add Finsupp.cons_support #10192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jcommelin
commented
Feb 2, 2024
jcommelin
commented
jcommelin
added
awaiting-review
urkud
reviewed
Feb 3, 2024
| @@ -92,4 +92,11 @@ theorem cons_ne_zero_iff : cons y s ≠ 0 ↔ y ≠ 0 ∨ s ≠ 0 := by | |||
| rw [h', c, Finsupp.cons_zero_zero] | |||
| #align finsupp.cons_ne_zero_iff Finsupp.cons_ne_zero_iff | |||
|
|
|||
| lemma cons_support : (s.cons y).support ⊆ insert 0 (s.support.map (Fin.succEmb n).toEmbedding) := by | |||
There was a problem hiding this comment.
Do we have a similar lemma about Fin.cons? IMHO, lemmas about Finsupp.cons should be mod_cast (lemma about Fin.cons), if possible.
There was a problem hiding this comment.
What would the lemma about Fin.cons be? The ingredients in the statement seem quite Finsupp-specific.
urkud
added
awaiting-author
jcommelin
added
awaiting-review
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Vierkantor
pushed a commit
that referenced
this pull request
Feb 5, 2024
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.