[Merged by Bors] - chore(Measure.FiniteMeasure): remove an @ replace with arguments for implicit parameters
#10194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobball
added
awaiting-CI
awaiting-review
|
Thanks 🎉 If CI passes, please remove the label bors d+ |
|
✌️ mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
leanprover-community-mathlib4-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on:
|
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 3, 2024
…r implicit parameters (#10194) The porting note seems to have slightly mis-diagnosed the problem here. This is more accurate and easier to read.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
@ replace with arguments for implicit parameters@ replace with arguments for implicit parameters
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
…r implicit parameters (#10194) The porting note seems to have slightly mis-diagnosed the problem here. This is more accurate and easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The porting note seems to have slightly mis-diagnosed the problem here. This is more accurate and easier to read.
I haven't pinpointed the exact issue yet but this form seems an improvement.