Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: DifferentiableOn.cpow #10203

Closed
wants to merge 6 commits into from

Conversation

llllvvuu
Copy link
Collaborator

@llllvvuu llllvvuu commented Feb 3, 2024

direct application of the content above it.


Open in Gitpod

@llllvvuu
Copy link
Collaborator Author

llllvvuu commented Feb 3, 2024

(context: this mirrors DifferentiableOn.rpow and would've golfed AlexKontorovich/PrimeNumberTheoremAnd#22 a bit)

@llllvvuu llllvvuu added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) labels Feb 3, 2024
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add Differentiable.cpow and Differentiable.const_cpow?

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 9, 2024
@llllvvuu llllvvuu added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 9, 2024
@@ -131,6 +131,22 @@ theorem DifferentiableWithinAt.const_cpow (hf : DifferentiableWithinAt ℂ f s x
(hf.hasFDerivWithinAt.const_cpow h0).differentiableWithinAt
#align differentiable_within_at.const_cpow DifferentiableWithinAt.const_cpow

theorem DifferentiableOn.cpow (hf : DifferentiableOn ℂ f s) (hg : DifferentiableOn ℂ g s)
(h0 : ∀ x ∈ s, f x ∈ slitPlane) : DifferentiableOn ℂ (fun x ↦ f x ^ g x) s :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the best spelling for h0 or should it be something like s ⊆ f ⁻¹' slitPlane?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be MapsTo f s slitPlane.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to MapsTo

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 12, 2024
@llllvvuu llllvvuu added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 12, 2024
@sgouezel
Copy link
Contributor

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 13, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
direct application of the content above it.



Co-authored-by: L Lllvvuu <git@llllvvuu.dev>
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 13, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: DifferentiableOn.cpow [Merged by Bors] - feat: DifferentiableOn.cpow Feb 13, 2024
@mathlib-bors mathlib-bors bot closed this Feb 13, 2024
@mathlib-bors mathlib-bors bot deleted the feat/differentiableon_cpow branch February 13, 2024 07:35
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
direct application of the content above it.



Co-authored-by: L Lllvvuu <git@llllvvuu.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants