Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: num and den lemmas #10219

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat: num and den lemmas #10219

wants to merge 1 commit into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Feb 3, 2024 •
edited

Add a few basic lemmas about Rat and NNRat and fix some lemma names

From LeanAPAP

Open in Gitpod

@YaelDillies
feat: num and den lemmas
08090e3 
Add a few basic lemmas about `Rat` and `NNRat` and fix some lemma names
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-order Order hierarchy labels Feb 3, 2024
jcommelin
jcommelin approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 3, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 3, 2024
@YaelDillies
feat: num and den lemmas (#10219)
b2f2f2c 
Add a few basic lemmas about `Rat` and `NNRat` and fix some lemma names

From LeanAPAP
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: num and den lemmas [Merged by Bors] - feat: num and den lemmas Feb 3, 2024
@mathlib-bors mathlib-bors bot closed this Feb 3, 2024
@mathlib-bors mathlib-bors bot deleted the num_den_pos branch February 3, 2024 15:39
atarnoam pushed a commit that referenced this pull request Feb 9, 2024
@YaelDillies @atarnoam
feat: num and den lemmas (#10219)
b34a668 
Add a few basic lemmas about `Rat` and `NNRat` and fix some lemma names

From LeanAPAP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @jcommelin @leanprover-community-mathlib4-bot