Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: Move LinearMap.ker to a new file #10233

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore: Move LinearMap.ker to a new file #10233

wants to merge 4 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde commented Feb 3, 2024 •
edited

This shortens Mathlib.LinearAlgebra.Basic, which is both longer than we like and doesn't have a clear scope.

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-review The author would like community review of the PR label Feb 3, 2024
@riccardobrasca
Copy link
Member

The motivation is that [Mathlib/LinearAlgebra/Basic.lean](https://github.com/leanprover-community/mathlib4/pull/10233/files#diff-6f14283bfbc75a32a870660bc104a4b628a3645bacef2d02343637199a25f517) is huge? It seems like a very good idea to me.

@jcommelin
Copy link
Member

What explains the +170 new lines? Not just a copyright header and module docstring, right?

@Ruben-VandeVelde
Copy link
Collaborator Author

The motivation is that [Mathlib/LinearAlgebra/Basic.lean](https://github.com/leanprover-community/mathlib4/pull/10233/files#diff-6f14283bfbc75a32a870660bc104a4b628a3645bacef2d02343637199a25f517) is huge? It seems like a very good idea to me.

Yes, exactly. Clarified in the summary.

What explains the +170 new lines? Not just a copyright header and module docstring, right?

It's the sections and variable lines and the empty lines between them, which I copied directly from LinearAlgebra.Basic. (I guess those are a mathport artefact? I wouldn't mind condensing them a bit.)

jcommelin
jcommelin approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 13, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
@Ruben-VandeVelde
chore: Move LinearMap.ker to a new file (#10233)
9b0cf85 
This shortens `Mathlib.LinearAlgebra.Basic`, which is both longer than we like and doesn't have a clear scope.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 13, 2024

Build failed (retrying...):

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 13, 2024

Canceled.

@jcommelin
Copy link
Member

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 14, 2024
@Ruben-VandeVelde
chore: Move LinearMap.ker to a new file (#10233)
e50aeb4 
This shortens `Mathlib.LinearAlgebra.Basic`, which is both longer than we like and doesn't have a clear scope.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 14, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Move LinearMap.ker to a new file [Merged by Bors] - chore: Move LinearMap.ker to a new file Feb 14, 2024
@mathlib-bors mathlib-bors bot closed this Feb 14, 2024
@mathlib-bors mathlib-bors bot deleted the linearmap-ker branch February 14, 2024 04:22
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
@Ruben-VandeVelde @riccardobrasca
chore: Move LinearMap.ker to a new file (#10233)
c85a97d 
This shortens `Mathlib.LinearAlgebra.Basic`, which is both longer than we like and doesn't have a clear scope.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@Ruben-VandeVelde @dagurtomas
chore: Move LinearMap.ker to a new file (#10233)
91b6ef9 
This shortens `Mathlib.LinearAlgebra.Basic`, which is both longer than we like and doesn't have a clear scope.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@riccardobrasca riccardobrasca riccardobrasca approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ruben-VandeVelde @riccardobrasca @jcommelin @leanprover-community-mathlib4-bot