New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Decidable
linter
#10235
Draft
urkud
wants to merge
214
commits into
master
Choose a base branch
from
YK-dec-lint
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: add Decidable
linter
#10235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found by a linter from #10235.
- Assume `{ι : Sort*} [Countable ι]` instead of `{ι : Type*} [Encodable ι]`. - Generalize 2nd Baire theorem from T₂ to R₁. - Rename type variables.
leanprover-community-mathlib4-bot
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Mar 30, 2024
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Apr 3, 2024
leanprover-community-mathlib4-bot
added
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
and removed
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
labels
Apr 11, 2024
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
Found by a WIP linter in #10235
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
Found by a WIP linter in #10235
leanprover-community-mathlib4-bot
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Apr 17, 2024
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Found by a WIP linter in #10235
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Found by a WIP linter in #10235
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Apr 24, 2024
leanprover-community-mathlib4-bot
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encodable
/Countable
#10250[Finite ι]
instead of[Fintype ι]
#10251DecidableEq
assumptions #10253DecidableEq
assumptions #10254DecidableEq
assumptions #10255[Fintype _]
->[Finite _]
#10257Fintype
assumption #10261