Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Absolute value and positive parts in pi types #10256

Closed
wants to merge 19 commits into from
Closed

[Merged by Bors] - feat: Absolute value and positive parts in pi types #10256

wants to merge 19 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Feb 4, 2024 •
edited

@YaelDillies
feat: Absolute value and positive parts in pi types
3347ab6 
and a few more lemmas

From LeanAPAP
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy labels Feb 4, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 5, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 5, 2024
Ruben-VandeVelde
Ruben-VandeVelde reviewed Feb 11, 2024
View reviewed changes
Mathlib/Algebra/GroupPower/Basic.lean Show resolved Hide resolved
Mathlib/Data/Pi/Algebra.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Order/Group/PosPart.lean Outdated Show resolved Hide resolved
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 15, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 16, 2024
@YaelDillies YaelDillies mentioned this pull request Feb 18, 2024
Closed
1 task
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 18, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 20, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 20, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 20, 2024
eric-wieser
eric-wieser approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@mathlib-bors
Copy link

mathlib-bors bot commented Mar 7, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Mar 7, 2024
@YaelDillies
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Mar 7, 2024
@YaelDillies
feat: Absolute value and positive parts in pi types (#10256)
87c01ca 
and a few more lemmas.

From LeanAPAP
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 7, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Absolute value and positive parts in pi types [Merged by Bors] - feat: Absolute value and positive parts in pi types Mar 7, 2024
@mathlib-bors mathlib-bors bot closed this Mar 7, 2024
@mathlib-bors mathlib-bors bot deleted the pi_abs branch March 7, 2024 23:02
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
@YaelDillies @kbuzzard
feat: Absolute value and positive parts in pi types (#10256)
ac8dc6c 
and a few more lemmas.

From LeanAPAP
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@YaelDillies @dagurtomas
feat: Absolute value and positive parts in pi types (#10256)
94d8b87 
and a few more lemmas.

From LeanAPAP
utensil pushed a commit that referenced this pull request Mar 26, 2024
@YaelDillies @utensil
feat: Absolute value and positive parts in pi types (#10256)
9a79d1f 
and a few more lemmas.

From LeanAPAP
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@YaelDillies @Louddy
feat: Absolute value and positive parts in pi types (#10256)
a78edf3 
and a few more lemmas.

From LeanAPAP
callesonne pushed a commit that referenced this pull request Apr 22, 2024
@YaelDillies @callesonne
feat: Absolute value and positive parts in pi types (#10256)
d7533e6 
and a few more lemmas.

From LeanAPAP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde left review comments

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YaelDillies @leanprover-community-mathlib4-bot @eric-wieser @Ruben-VandeVelde