Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: remove Fintype.card_fin_even #10273

Closed
wants to merge 1 commit into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

This instance was meant to apply to even literal numbers. Because Lean 4 no longer uses bit0/bit1 for literals, it no longer serves that purpose. Instead, a specific instance for Fin 2 is added.


Open in Gitpod

This instance was meant to apply to even literal numbers.
Because Lean 4 no longer uses bit0/bit1 for literals, it no longer serves that purpose.
Instead, a specific instance for Fin 2 is added.
@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-review The author would like community review of the PR label Feb 5, 2024
@urkud
Copy link
Member

urkud commented Feb 11, 2024

Thanks! 🎉
bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 11, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 11, 2024
This instance was meant to apply to even literal numbers. Because Lean 4 no longer uses bit0/bit1 for literals, it no longer serves that purpose. Instead, a specific instance for Fin 2 is added.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 11, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove Fintype.card_fin_even [Merged by Bors] - chore: remove Fintype.card_fin_even Feb 11, 2024
@mathlib-bors mathlib-bors bot closed this Feb 11, 2024
@mathlib-bors mathlib-bors bot deleted the Fintype.card_fin_even branch February 11, 2024 04:23
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
This instance was meant to apply to even literal numbers. Because Lean 4 no longer uses bit0/bit1 for literals, it no longer serves that purpose. Instead, a specific instance for Fin 2 is added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants