[Merged by Bors] - refactor: move natural isomorphisms involving inverses of equivalences #10278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwoFX
added
awaiting-review
|
It seems that the syntax for deprecation would be like: @[deprecated] -- since 2024-02-06
alias compInvIso := Iso.compInvIso |
joelriou
added
awaiting-author
joelriou
reviewed
Feb 6, 2024
TwoFX
added
awaiting-review
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
#10278) - Move all results from `CategoryTheory/Functor/InvIsos.lean` to `CategoryTheory/Equivalence.lean` and delete the former file - Replace use of `eqToIso (Functor.comp_id G)` with `G.rightUnitor` - Move into `Iso` namespace to enable dot notation - Add analogous results stated in terms of `Equivalence` instead of `IsEquivalence`
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
#10278) - Move all results from `CategoryTheory/Functor/InvIsos.lean` to `CategoryTheory/Equivalence.lean` and delete the former file - Replace use of `eqToIso (Functor.comp_id G)` with `G.rightUnitor` - Move into `Iso` namespace to enable dot notation - Add analogous results stated in terms of `Equivalence` instead of `IsEquivalence`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CategoryTheory/Functor/InvIsos.leantoCategoryTheory/Equivalence.leanand delete the former fileeqToIso (Functor.comp_id G)withG.rightUnitorIsonamespace to enable dot notationEquivalenceinstead ofIsEquivalenceI have to admit that I'm not up to date on the discussion regarding renamings and deprecations. Do I have to add some kind of align statement or deprecation notice due to moving the definitions from
Mathlib.CategoryTheorytoMathlib.CategoryTheory.Iso?