Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Topology/Bases): review IsSeparable API #10286

Closed
wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 5, 2024

  • upgrade isSeparable_iUnion to an Iff lemma, restore the original version as IsSeparable.iUnion;
  • add isSeparable_union and isSeparable_closure;
  • upgrade isSeparable_pi from [Finite ι] to [Countable ι], add IsSeparable.univ_pi version;
  • add Dense.isSeparable_iff and isSeparable_range;
  • rename isSeparable_of_separableSpace_subtype to IsSeparable.of_subtype;
  • rename isSeparable_of_separableSpace to IsSeparable.of_separableSpace.

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters labels Feb 5, 2024
@sgouezel
Copy link
Contributor

sgouezel commented Feb 6, 2024

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 6, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 6, 2024
* upgrade `isSeparable_iUnion` to an `Iff` lemma, restore the original version as `IsSeparable.iUnion`;
* add `isSeparable_union` and `isSeparable_closure`;
* upgrade `isSeparable_pi` from `[Finite ι]` to `[Countable ι]`, add `IsSeparable.univ_pi` version;
* add `Dense.isSeparable_iff` and `isSeparable_range`;
* rename `isSeparable_of_separableSpace_subtype` to `IsSeparable.of_subtype`;
* rename `isSeparable_of_separableSpace` to `IsSeparable.of_separableSpace`.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 6, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/Bases): review IsSeparable API [Merged by Bors] - feat(Topology/Bases): review IsSeparable API Feb 6, 2024
@mathlib-bors mathlib-bors bot closed this Feb 6, 2024
@mathlib-bors mathlib-bors bot deleted the YK-sep-api branch February 6, 2024 08:35
atarnoam pushed a commit that referenced this pull request Feb 9, 2024
* upgrade `isSeparable_iUnion` to an `Iff` lemma, restore the original version as `IsSeparable.iUnion`;
* add `isSeparable_union` and `isSeparable_closure`;
* upgrade `isSeparable_pi` from `[Finite ι]` to `[Countable ι]`, add `IsSeparable.univ_pi` version;
* add `Dense.isSeparable_iff` and `isSeparable_range`;
* rename `isSeparable_of_separableSpace_subtype` to `IsSeparable.of_subtype`;
* rename `isSeparable_of_separableSpace` to `IsSeparable.of_separableSpace`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants