Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: Matrix.mulVec and Matrix.vecMul get infix notation #10297

Closed
wants to merge 15 commits into from
Closed

[Merged by Bors] - chore: Matrix.mulVec and Matrix.vecMul get infix notation #10297

wants to merge 15 commits into from

Conversation

madvorak
Copy link
Collaborator

@madvorak madvorak commented Feb 6, 2024 •
edited

@madvorak madvorak added the WIP Work in progress label Feb 6, 2024
@madvorak madvorak added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Feb 6, 2024
madvorak and others added 3 commits February 6, 2024 18:47
@madvorak @eric-wieser
Update Mathlib/LinearAlgebra/Matrix/LDL.lean
ee7d228 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@madvorak @eric-wieser
Update Mathlib/Data/Matrix/Notation.lean
86f3861 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
parentheses around of removed
777ef27
kmill
kmill approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@kmill kmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to ask another maintainer to double-check, but I think this looks good.

maintainer merge

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

🚀 Pull request has been placed on the maintainer queue by kmill.

jcommelin
jcommelin approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 7, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 7, 2024
@madvorak
chore: Matrix.mulVec and Matrix.vecMul get infix notation (#10297)
deb48fa 
Zulip discussion:
https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Notation.20for.20mul_vec.20and.20vec_mul



Co-authored-by: Martin Dvorak <mdvorak@ista.ac.at>
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 7, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Matrix.mulVec and Matrix.vecMul get infix notation [Merged by Bors] - chore: Matrix.mulVec and Matrix.vecMul get infix notation Feb 7, 2024
@mathlib-bors mathlib-bors bot closed this Feb 7, 2024
@mathlib-bors mathlib-bors bot deleted the matrixvector branch February 7, 2024 06:34
atarnoam pushed a commit that referenced this pull request Feb 9, 2024
@madvorak @atarnoam
chore: Matrix.mulVec and Matrix.vecMul get infix notation (#10297)
635727f 
Zulip discussion:
https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Notation.20for.20mul_vec.20and.20vec_mul



Co-authored-by: Martin Dvorak <mdvorak@ista.ac.at>
@hrmacbeth hrmacbeth mentioned this pull request May 23, 2024
Closed
mathlib-bors bot pushed a commit that referenced this pull request May 23, 2024
@hrmacbeth
fix: matrix simp-set error (#13134)
9b7a59c 
Correct an error in the statement of the lemma `Matrix.cons_vecMul` introduced in #10297 (as can be seen by checking the diff on that PR, cc @madvorak).

Add the example via which I caught this error, as a test case for the matrix simp-set.
grunweg pushed a commit that referenced this pull request May 24, 2024
@hrmacbeth @grunweg
fix: matrix simp-set error (#13134)
64931de 
Correct an error in the statement of the lemma `Matrix.cons_vecMul` introduced in #10297 (as can be seen by checking the diff on that PR, cc @madvorak).

Add the example via which I caught this error, as a test case for the matrix simp-set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@newell newell newell left review comments

@kmill kmill kmill approved these changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@madvorak @kmill @eric-wieser @newell @jcommelin @leanprover-community-mathlib4-bot