Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(RingTheory/MvPolynomial): funext for homogeneous polynomials #10300

Closed
wants to merge 5 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin commented Feb 6, 2024


Open in Gitpod

@jcommelin jcommelin added awaiting-review The author would like community review of the PR awaiting-CI labels Feb 6, 2024
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nitpicks but LGTM.

Thanks!

bors d+

Mathlib/RingTheory/MvPolynomial/Homogeneous.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/MvPolynomial/Homogeneous.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/MvPolynomial/Homogeneous.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/MvPolynomial/Homogeneous.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/MvPolynomial/Homogeneous.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 6, 2024

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 6, 2024
Mathlib/RingTheory/MvPolynomial/Homogeneous.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/MvPolynomial/Homogeneous.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/MvPolynomial/Homogeneous.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/MvPolynomial/Homogeneous.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/MvPolynomial/Homogeneous.lean Outdated Show resolved Hide resolved
@jcommelin
Copy link
Member Author

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 7, 2024
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 7, 2024

Build failed (retrying...):

  • Build

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 7, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/MvPolynomial): funext for homogeneous polynomials [Merged by Bors] - feat(RingTheory/MvPolynomial): funext for homogeneous polynomials Feb 7, 2024
@mathlib-bors mathlib-bors bot closed this Feb 7, 2024
@mathlib-bors mathlib-bors bot deleted the homogeneous-funext branch February 7, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants