Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Equiv/Fintype): Fintype -> Finite in Equiv.toCompl #10305

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(Equiv/Fintype): Fintype -> Finite in Equiv.toCompl #10305

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 6, 2024

Also drop DecidablePred assumptions.

Open in Gitpod

@urkud
chore(Equiv/Fintype): Fintype -> Finite in Equiv.toCompl
ad5ad37 
Also drop `DecidablePred` assumptions.
@urkud urkud added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-logic Logic (model theory, set theory, etc) labels Feb 6, 2024
@adomani
Copy link
Collaborator

adomani commented Feb 6, 2024 •
edited

maintainer merge

(note the two spaces between maintainer and merge)
EDIT: they appear when I edit, but they do not get displayed!

@adomani
Copy link
Collaborator

adomani commented Feb 6, 2024

maintainer merge

(This time, just a single space between the words)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

🚀 Pull request has been placed on the maintainer queue by adomani.

@kmill
Copy link
Contributor

kmill commented Feb 6, 2024

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 6, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 6, 2024
@urkud
chore(Equiv/Fintype): Fintype -> Finite in Equiv.toCompl (#10305)
3dc8a1d 
Also drop `DecidablePred` assumptions.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 6, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Equiv/Fintype): Fintype -> Finite in Equiv.toCompl [Merged by Bors] - chore(Equiv/Fintype): Fintype -> Finite in Equiv.toCompl Feb 6, 2024
@mathlib-bors mathlib-bors bot closed this Feb 6, 2024
@mathlib-bors mathlib-bors bot deleted the YK-equiv-toCompl branch February 6, 2024 23:09
atarnoam pushed a commit that referenced this pull request Feb 9, 2024
@urkud @atarnoam
chore(Equiv/Fintype): Fintype -> Finite in Equiv.toCompl (#10305)
4b89177 
Also drop `DecidablePred` assumptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, set theory, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @adomani @kmill