Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: extend AddMonoidAlgebra.supDegree API #10355

Closed
wants to merge 2 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

This is a part of #7173 that I hope will be uncontroversial.


Open in Gitpod

This is a part of #7173 that I hope will be uncontroversial.

Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-review The author would like community review of the PR label Feb 8, 2024
Copy link
Collaborator

@adomani adomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Mathlib/Algebra/MonoidAlgebra/Degree.lean Show resolved Hide resolved
Mathlib/Algebra/MonoidAlgebra/Degree.lean Show resolved Hide resolved
@adomani
Copy link
Collaborator

adomani commented Feb 8, 2024

(I did not check whether simp already proved the lemmas, though...)

Co-authored-by: damiano <adomani@gmail.com>

variable [CovariantClass B B (· + ·) (· < ·)] [CovariantClass B B (Function.swap (· + ·)) (· < ·)]

theorem apply_add_of_supDegree_eq (hD : D.Injective) {ap aq : A}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've definitely seen some form of this lemma. This probably means that you can use this lemma to golf a similar proof somewhere in the Polynomial.coeff_mul_of_degree_le-range (made up name, but I have to go now!).

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge this. Potential unlocked golfing can be done in a follow-up.

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 13, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
This is a part of #7173 that I hope will be uncontroversial.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 13, 2024

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
This is a part of #7173 that I hope will be uncontroversial.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 13, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
This is a part of #7173 that I hope will be uncontroversial.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 13, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
This is a part of #7173 that I hope will be uncontroversial.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 13, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
This is a part of #7173 that I hope will be uncontroversial.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 13, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: extend AddMonoidAlgebra.supDegree API [Merged by Bors] - feat: extend AddMonoidAlgebra.supDegree API Feb 13, 2024
@mathlib-bors mathlib-bors bot closed this Feb 13, 2024
@mathlib-bors mathlib-bors bot deleted the supDegree branch February 13, 2024 23:17
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
This is a part of #7173 that I hope will be uncontroversial.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
This is a part of #7173 that I hope will be uncontroversial.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants