Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Eisenstein series uniform convergence #10377

Closed
wants to merge 143 commits into from

Conversation

CBirkbeck
Copy link
Collaborator

@CBirkbeck CBirkbeck commented Feb 9, 2024

We show that the sum defining an Eisenstein Series converges locally uniformly. This is the basis for later proving that they are holomorphic (see #11013 ) and bounded at infinity (see #12456), which combine to show they are modular forms (see #12604).


CBirkbeck and others added 18 commits February 6, 2024 17:48
…mposition.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…mposition.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@CBirkbeck CBirkbeck added the WIP Work in progress label Feb 9, 2024
@loefflerd
Copy link
Collaborator

The main changes I made were:

  • rather than writing max (x 0).natAbs ... each time, I used the handy fact that Fin 2 → ℤ has a pre-defined norm and it's the sup-norm, so we can just write ‖x‖.
  • You had various lemmas involving Finset.box that depended on z; but I think it's better to gather together all the references to Finset.box into the proof of the single lemma
    lemma summable_one_div_norm_rpow {k : ℝ} (hk : 2 < k) :
        Summable fun (x : Fin 2 → ℤ) ↦ ‖x‖ ^ (-k) := by
    which is hopefully interesting outside the context of this particular PR.
  • I added an outline of the argument at the start of the file.

@CBirkbeck
Copy link
Collaborator Author

CBirkbeck commented May 15, 2024

I didn't know we had this norm on tuples, which I think really makes it much cleaner, so thank you! and thanks for the extra doc strings, I usually only add then to defs, but I this is a good idea going forward. The only thing I changed (other than some short golf) was the name norm_def to norm_eq_max_natAbs as its maybe more standard?

Copy link
Collaborator

@loefflerd loefflerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great – let's get this in!

Note to maintainers: the code is now kind of a joint effort, but Chris has carefully read the bits that I wrote, and vice versa, so I think we can count it all as being "reviewed".

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by loefflerd.

@riccardobrasca
Copy link
Member

Modulo Johan's comment LGTM, thanks!

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented May 15, 2024

✌️ CBirkbeck can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels May 15, 2024
CBirkbeck and others added 2 commits May 15, 2024 12:14
…ergence.lean

Co-authored-by: Johan Commelin <johan@commelin.net>
@CBirkbeck
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request May 15, 2024
We show that the sum defining an Eisenstein Series converges locally uniformly. This is the basis for later proving that they are holomorphic (see #11013 ) and bounded at infinity (see #12456), which combine to show they are modular forms (see #12604).




Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
Co-authored-by: David Loeffler <d.loeffler.01@cantab.net>
@mathlib-bors
Copy link

mathlib-bors bot commented May 15, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title Eisenstein series uniform convergence [Merged by Bors] - Eisenstein series uniform convergence May 15, 2024
@mathlib-bors mathlib-bors bot closed this May 15, 2024
@mathlib-bors mathlib-bors bot deleted the eisensteinSeries_Uniform_convergence branch May 15, 2024 12:02
callesonne pushed a commit that referenced this pull request May 16, 2024
We define the vertical strips that are needed for proving Eisenstein series are modular forms #10377 . We also add the definition of sqrt{-1} as an elements of the upper half plane. Note that this is no longer needed for the modular forms PRs but its good to have.

Sorry about the typo in the PR name, its not my day!



Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
callesonne pushed a commit that referenced this pull request May 16, 2024
Add `eq_zero_iff_eq_zero_of_mem_box` lemma needed for #10377
callesonne pushed a commit that referenced this pull request May 16, 2024
We also  `summable_partition` (and the required  `Set.sigmaEquiv`), needed for #10377.  



Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
callesonne pushed a commit that referenced this pull request May 16, 2024
We show that the sum defining an Eisenstein Series converges locally uniformly. This is the basis for later proving that they are holomorphic (see #11013 ) and bounded at infinity (see #12456), which combine to show they are modular forms (see #12604).




Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
Co-authored-by: David Loeffler <d.loeffler.01@cantab.net>
grunweg pushed a commit that referenced this pull request May 17, 2024
We show that the sum defining an Eisenstein Series converges locally uniformly. This is the basis for later proving that they are holomorphic (see #11013 ) and bounded at infinity (see #12456), which combine to show they are modular forms (see #12604).




Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
Co-authored-by: David Loeffler <d.loeffler.01@cantab.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants