[Merged by Bors] - fix: improve the logging behavior of slim_check
#10393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in the tactic that meant it would always print "no goals to be solved". This also promotes the code-generation from `IO` to `CoreM`, so that the output can be sent through the logging infrastructure rather than `IO.println`.
eric-wieser
added
bug
eric-wieser
commented
Feb 9, 2024
Comment on lines
+555
to
+557
| | TestResult.success _ => if !cfg.quiet then Lean.logInfo "Success" | ||
| | TestResult.gaveUp n => if !cfg.quiet then Lean.logWarning s!"Gave up {n} times" | ||
| | TestResult.failure _ xs n => Lean.throwError <| formatFailure "Found problems!" xs n |
There was a problem hiding this comment.
The wording could probably be improved here, but I'd prefer to declare that out of scope; this PR is blocking a bug fix elsewhere, as we cannot write tests without it.
1 task
eric-wieser
added
the
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 10, 2024
There was a bug in the tactic that meant it would always print "no goals to be solved". This also promotes the code-generation from `IO` to `CoreM`, so that the output can be sent through the logging infrastructure rather than `IO.println`. This is important, because tests are not allowed to be noisy, and we have no way to capture `IO` output.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
slim_checkslim_check
atarnoam
pushed a commit
that referenced
this pull request
Feb 10, 2024
There was a bug in the tactic that meant it would always print "no goals to be solved". This also promotes the code-generation from `IO` to `CoreM`, so that the output can be sent through the logging infrastructure rather than `IO.println`. This is important, because tests are not allowed to be noisy, and we have no way to capture `IO` output.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
There was a bug in the tactic that meant it would always print "no goals to be solved". This also promotes the code-generation from `IO` to `CoreM`, so that the output can be sent through the logging infrastructure rather than `IO.println`. This is important, because tests are not allowed to be noisy, and we have no way to capture `IO` output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the tactic that meant it would always print "no goals to be solved".
This also promotes the code-generation from
IOtoCoreM, so that the output can be sent through the logging infrastructure rather thanIO.println.This is important, because tests are not allowed to be noisy, and we have no way to capture
IOoutput.