New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(*): use notation for nhds #10416
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
The author would like community review of the PR
t-topology
Topological spaces, uniform spaces, metric spaces, filters
labels
Feb 11, 2024
eric-wieser
reviewed
Feb 11, 2024
eric-wieser
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
Thanks!
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 11, 2024
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2024
Also fix `GeneralizedContinuedFraction.of_convergence`: it worked for the `Preorder.topology` only.
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore(*): use notation for nhds
[Merged by Bors] - chore(*): use notation for nhds
Feb 11, 2024
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
Also fix `GeneralizedContinuedFraction.of_convergence`: it worked for the `Preorder.topology` only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
delegated
ready-to-merge
This PR has been sent to bors.
t-topology
Topological spaces, uniform spaces, metric spaces, filters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix
GeneralizedContinuedFraction.of_convergence
:it worked for the
Preorder.topology
only.