Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: an irreducible real polynomial has degree ≤2 #10431

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: an irreducible real polynomial has degree ≤2 #10431

wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 11, 2024

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) t-algebra Algebra (groups, rings, fields etc) labels Feb 11, 2024
grunweg
grunweg approved these changes Feb 11, 2024
View reviewed changes
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me. The proof is surprisingly readable!
(confidence low; I'm barely know this area of mathlib)

adomani
adomani reviewed Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@adomani adomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean proof!

Mathlib/Data/IsROrC/Lemmas.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/Complex/Polynomial.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 13, 2024
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 14, 2024
@urkud urkud requested a review from adomani February 14, 2024 06:46
@adomani
Copy link
Collaborator

adomani commented Feb 14, 2024

Thanks!

maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by adomani.

jcommelin
jcommelin approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 14, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 14, 2024
@urkud
feat: an irreducible real polynomial has degree ≤2 (#10431)
30c9985
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 14, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: an irreducible real polynomial has degree ≤2 [Merged by Bors] - feat: an irreducible real polynomial has degree ≤2 Feb 14, 2024
@mathlib-bors mathlib-bors bot closed this Feb 14, 2024
@mathlib-bors mathlib-bors bot deleted the YK-irreducible-degree branch February 14, 2024 09:39
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
@urkud @riccardobrasca
feat: an irreducible real polynomial has degree ≤2 (#10431)
cc32a81
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@urkud @dagurtomas
feat: an irreducible real polynomial has degree ≤2 (#10431)
cdc3a90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@grunweg grunweg grunweg approved these changes

@adomani adomani Awaiting requested review from adomani

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc) t-analysis Analysis (normed *, calculus)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@urkud @adomani @jcommelin @grunweg @leanprover-community-mathlib4-bot