[Merged by Bors] - refactor: prefer s ∩ . when passing to a subset of s
#10433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is partial work to make `Subtype.val '' .` and `s ∩ .` be consistently used as adjoint operators for passing to and from a "subspace".
eric-wieser
reviewed
Feb 11, 2024
eric-wieser
reviewed
Feb 11, 2024
| @@ -1679,7 +1679,7 @@ theorem mem_subgroupOf {H K : Subgroup G} {h : K} : h ∈ H.subgroupOf K ↔ (h | |||
|
|
|||
| @[to_additive (attr := simp)] | |||
| theorem subgroupOf_map_subtype (H K : Subgroup G) : (H.subgroupOf K).map K.subtype = H ⊓ K := | |||
There was a problem hiding this comment.
Arguably this should flip too
eric-wieser
added
awaiting-author
kmill
added
awaiting-review
jcommelin
reviewed
Feb 14, 2024
jcommelin
added
awaiting-author
|
Can you edit the description to link to the Zulip thread, @kmill? |
|
@jcommelin I only did fixups -- inserting
Why? |
|
The diff suggests to me that you would need to do fewer fixups. |
jcommelin
added
awaiting-review
|
@kmill privately explained to me that he would like "passing to a subset" to behave more like a prefix operator. Which I think is a good reason. So then this is the order it should be. bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
This is partial work to make `s ∩ .` be consistently used for passing to a subset of `s`. This is sort of an adjoint to `(Subtype.val : s -> _) '' .`, except for the fact that it does not produce a `Set s`. The main API changes are to `Subtype.image_preimage_val` and `Subtype.preimage_val_eq_preimage_val_iff` in `Mathlib.Data.Set.Image`. Changes in other modules are all proof fixups. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Passing.20to.20subsets.20of.20a.20subspace/near/420917406)
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
s ∩ . when passing to a subset of ss ∩ . when passing to a subset of s
riccardobrasca
pushed a commit
that referenced
this pull request
Feb 18, 2024
This is partial work to make `s ∩ .` be consistently used for passing to a subset of `s`. This is sort of an adjoint to `(Subtype.val : s -> _) '' .`, except for the fact that it does not produce a `Set s`. The main API changes are to `Subtype.image_preimage_val` and `Subtype.preimage_val_eq_preimage_val_iff` in `Mathlib.Data.Set.Image`. Changes in other modules are all proof fixups. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Passing.20to.20subsets.20of.20a.20subspace/near/420917406)
miguelmarco
added a commit
that referenced
this pull request
Feb 19, 2024
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
This is partial work to make `s ∩ .` be consistently used for passing to a subset of `s`. This is sort of an adjoint to `(Subtype.val : s -> _) '' .`, except for the fact that it does not produce a `Set s`. The main API changes are to `Subtype.image_preimage_val` and `Subtype.preimage_val_eq_preimage_val_iff` in `Mathlib.Data.Set.Image`. Changes in other modules are all proof fixups. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Passing.20to.20subsets.20of.20a.20subspace/near/420917406)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is partial work to make
s ∩ .be consistently used for passing to a subset ofs. This is sort of an adjoint to(Subtype.val : s -> _) '' ., except for the fact that it does not produce aSet s.The main API changes are to
Subtype.image_preimage_valandSubtype.preimage_val_eq_preimage_val_iffinMathlib.Data.Set.Image. Changes in other modules are all proof fixups.Zulip discussion